Ebonilla/sy 742 fix issues with recreating channels with the same name #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LeonLiur
reviewed
Jun 6, 2024
client/py/synnax/channel/retrieve.py
Outdated
| normal = normalize_channel_params(keys) | ||
| if normal.variant == "names": | ||
| for name in normal.params: | ||
| key = self.__names_to_keys.get(name) |
There was a problem hiding this comment.
A name may correspond to multiple channels
…la/sy-742-fix-issues-with-recreating-channels-with-the-same-name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc #624 +/- ##
=======================================
Coverage 51.63% 51.63%
=======================================
Files 1040 1040
Lines 78432 78432
Branches 3249 3249
=======================================
Hits 40500 40500
Misses 36962 36962
Partials 970 970
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pjdotson
deleted the
ebonilla/sy-742-fix-issues-with-recreating-channels-with-the-same-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.