Ebonilla/sy 749 opc ua read task cleanup and tests #640

emilbon99 · 2024-06-14T05:12:28Z

No description provided.

…sy-693-support-for-cesium-writer-err-on-unauthorized

…nto 585-sy-693-support-for-cesium-writer-err-on-unauthorized

…d' of https://github.com/synnaxlabs/synnax into ebonilla/sy-749-opc-ua-read-task-cleanup-and-tests

…nto ebonilla/sy-749-opc-ua-read-task-cleanup-and-tests

…la/sy-749-opc-ua-read-task-cleanup-and-tests

vercel · 2024-06-14T05:12:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 14, 2024 8:32pm

codecov · 2024-06-14T05:14:10Z

Codecov Report

Attention: Patch coverage is 53.04878% with 77 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc@f8f5082). Learn more about missing BASE report.

Files	Patch %	Lines
synnax/pkg/api/grpc/v1/hardware.pb.go	0.00%	15 Missing ⚠️
synnax/pkg/api/grpc/hardware.go	0.00%	14 Missing ⚠️
synnax/pkg/hardware/task/service.go	35.71%	6 Missing and 3 partials ⚠️
synnax/pkg/hardware/service.go	0.00%	7 Missing ⚠️
synnax/pkg/hardware/task/retrieve.go	22.22%	6 Missing and 1 partial ⚠️
synnax/pkg/api/grpc/v1/channel.pb.go	0.00%	5 Missing ⚠️
synnax/pkg/api/hardware.go	0.00%	5 Missing ⚠️
x/go/gorp/delete.go	84.84%	4 Missing and 1 partial ⚠️
cesium/internal/unary/writer.go	57.14%	2 Missing and 1 partial ⚠️
cesium/internal/virtual/db.go	85.00%	2 Missing and 1 partial ⚠️
... and 3 more

Additional details and impacted files

@@          Coverage Diff          @@
##             rc     #640   +/-   ##
=====================================
  Coverage      ?   51.64%           
=====================================
  Files         ?     1040           
  Lines         ?    78517           
  Branches      ?     3249           
=====================================
  Hits          ?    40554           
  Misses        ?    36988           
  Partials      ?      975

Flag	Coverage Δ
aspen	`50.18% <ø> (?)`
cesium	`73.02% <73.33%> (?)`
clientpy	`87.38% <ø> (?)`
clientts	`86.67% <100.00%> (?)`
gox	`58.25% <84.84%> (?)`
synnax	`27.20% <30.43%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…la/sy-749-opc-ua-read-task-cleanup-and-tests

LeonLiur

Good after some minor changes

LeonLiur · 2024-06-14T13:48:56Z

cesium/internal/virtual/db.go

+func Open(configs ...Config) (db *DB, err error) {
+	cfg, err := config.New(DefaultConfig, configs...)
+	if err != nil {
+		return nil, err


LeonLiur · 2024-06-14T13:49:02Z

cesium/internal/virtual/db.go

+	c, err := controller.New[*controlEntity](controller.Config{
+		Concurrency:     control.Shared,
+		Instrumentation: cfg.Instrumentation,
+	})
 	if err != nil {
 		return nil, err


LeonLiur · 2024-06-14T13:50:14Z

cesium/internal/virtual/write_test.go

@@ -20,6 +21,7 @@ var _ = Describe("Write", func() {
 				DataType: telem.TimeStampT,
 				Virtual:  true,
 			},
+			FS: xfs.NewMem(),


Why only mem FS?

FS implementation is still checked for in the config but does not apply to any test cases. Feel free to adjust as you build out future test suites

LeonLiur · 2024-06-14T13:51:09Z

client/cpp/framer/frame.cpp

@@ -59,9 +59,9 @@ void Frame::toProto(api::v1::Frame *f) const {

 // implement th ostream operator


LeonLiur · 2024-06-14T13:58:10Z

client/cpp/framer/framer.h

@@ -170,9 +170,9 @@ class Streamer {
 };

 enum WriterMode : uint8_t {


Do we still need WriteMode if we got rid of SetMode?

Yes, you can set the mode when opening the writer

LeonLiur · 2024-06-14T14:06:15Z

client/cpp/hardware/hardware.cpp

+}
+
+
+std::pair<Task, freighter::Error> TaskClient::retrieveByType(


why are some functions snake case and some functions camel case?

We need to standardize the convention we use. I'll leave this to @Lham42 as a chore

LeonLiur · 2024-06-14T14:09:59Z

client/py/examples/control/tpc/change_detection.py

+                time_range=sy.TimeRange(
+                    start=above_threshold, end=value["daq_time"][-1]
+                ),
+                color="#BADA55",


interesting hex

…la/sy-749-opc-ua-read-task-cleanup-and-tests

LeonLiur and others added 28 commits May 28, 2024 11:49

[cesium] - added test case for ErrOnUnauthorized

abca46a

[synnax] - added service support for ErrOnUnauthorized

6dffeca

[client] - Added tests and support for ErrOnUnauthorized

5fac362

[ops] - Bumped VERSION

2f6096f

[client] - added error on authorized parameter to writer config

8e6fdb2

Merge branch 'main' of https://github.com/synnaxlabs/synnax into 585-…

2447422

…sy-693-support-for-cesium-writer-err-on-unauthorized

[driver/opc] - frame refactoring

a878a78

Merge branch 'synnax-21-rc' of https://github.com/synnaxlabs/synnax i…

845ed3d

…nto 585-sy-693-support-for-cesium-writer-err-on-unauthorized

[client/cpp] - implement test cases for error on unauthorized

7b3bd54

[client/cpp] - added writer config defaults

af15bae

[pipeline] - refactoring and test cases for accurate behaviro

bb11bf9

[driver] - made some touchups to the OPC read task

3b4a2d4

[driver] - implemented basic data saving

93543bb

[cesium] - fixed a number of race conditions

ddca8e3

[cesium] - removed unsafe property access from commit

c42852c

[cesium] - added error checkon fs rename during channel delete

1136f44

[cesium] - fixed typo

ff6558e

[framer/api] - added documentation to err on unauthorized

a69d39a

[cesium] - removed mutex lock from directory removal on cahnnel deletion

2798298

Merge branch 'synnax-21-rc' of https://github.com/synnaxlabs/synnax i…

7aa4e05

…nto 585-sy-693-support-for-cesium-writer-err-on-unauthorized

[cesium] - minor touchups related to control and mutex locking

c536471

Merge branch '585-sy-693-support-for-cesium-writer-err-on-unauthorize…

1f1c0fd

…d' of https://github.com/synnaxlabs/synnax into ebonilla/sy-749-opc-ua-read-task-cleanup-and-tests

Merge branch 'synnax-21-rc' of https://github.com/synnaxlabs/synnax i…

6ebdf91

…nto ebonilla/sy-749-opc-ua-read-task-cleanup-and-tests

[driver] - refactoring and documentation

1f5c005

Merge branch 'synnax-21-rc' of https://github.com/synnaxlabs/synnax i…

0f00f60

…nto ebonilla/sy-749-opc-ua-read-task-cleanup-and-tests

[driver] - tuning

5d305da

Merge branch 'rc' of https://github.com/synnaxlabs/synnax into ebonil…

b859f99

…la/sy-749-opc-ua-read-task-cleanup-and-tests

[client/cpp] - fixed issues with series copy constructor by removing it

95d8623

[client/py] - black reformatting

c3a292a

emilbon99 requested review from Lham42 and LeonLiur June 14, 2024 05:30

vercel bot deployed to Preview June 14, 2024 05:30 View deployment

[state/tracker] - fixed issue with test cases

4dcdf7f

vercel bot deployed to Preview June 14, 2024 05:34 View deployment

Merge branch 'rc' of https://github.com/synnaxlabs/synnax into ebonil…

fe6a4e8

…la/sy-749-opc-ua-read-task-cleanup-and-tests

vercel bot deployed to Preview June 14, 2024 05:39 View deployment

[cesium] - resolved issues with virtual writer test cases

71aca51

vercel bot deployed to Preview June 14, 2024 05:43 View deployment

[driver] - resolved build issues on ubuntu

06dd7fc

vercel bot deployed to Preview June 14, 2024 05:45 View deployment

[driver] - resolved build issues on ubuntu

36a2c4c

vercel bot deployed to Preview June 14, 2024 05:50 View deployment

[driver] - resolved build issues on ubuntu

c918cca

vercel bot deployed to Preview June 14, 2024 05:53 View deployment

LeonLiur approved these changes Jun 14, 2024

View reviewed changes

[client/cpp] - minor refactoring and import sorting

d561ba9

vercel bot deployed to Preview June 14, 2024 18:44 View deployment

[driver] - fixed client tests and updated loop tests in driver

8985eb0

vercel bot deployed to Preview June 14, 2024 20:12 View deployment

[ops] - added client cpp tests to CI

6d26177

vercel bot deployed to Preview June 14, 2024 20:16 View deployment

Merge branch 'rc' of https://github.com/synnaxlabs/synnax into ebonil…

6efc309

…la/sy-749-opc-ua-read-task-cleanup-and-tests

vercel bot deployed to Preview June 14, 2024 20:20 View deployment

[client/cpp] - updated chrono include

aedfedd

vercel bot deployed to Preview June 14, 2024 20:32 View deployment

Lham42 approved these changes Jun 15, 2024

View reviewed changes

Lham42 merged commit d2e8e26 into rc Jun 15, 2024
49 checks passed

emilbon99 deleted the ebonilla/sy-749-opc-ua-read-task-cleanup-and-tests branch July 1, 2024 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ebonilla/sy 749 opc ua read task cleanup and tests #640

Ebonilla/sy 749 opc ua read task cleanup and tests #640

emilbon99 commented Jun 14, 2024

vercel bot commented Jun 14, 2024 •

edited

Loading

codecov bot commented Jun 14, 2024 •

edited

Loading

LeonLiur left a comment

LeonLiur Jun 14, 2024

LeonLiur Jun 14, 2024

LeonLiur Jun 14, 2024

emilbon99 Jun 14, 2024

LeonLiur Jun 14, 2024

LeonLiur Jun 14, 2024

emilbon99 Jun 14, 2024

LeonLiur Jun 14, 2024

emilbon99 Jun 14, 2024

LeonLiur Jun 14, 2024

emilbon99 Jun 14, 2024

		@@ -59,9 +59,9 @@ void Frame::toProto(api::v1::Frame *f) const {

		// implement th ostream operator

		@@ -170,9 +170,9 @@ class Streamer {
		};

		enum WriterMode : uint8_t {

		}


		std::pair<Task, freighter::Error> TaskClient::retrieveByType(

Ebonilla/sy 749 opc ua read task cleanup and tests #640

Ebonilla/sy 749 opc ua read task cleanup and tests #640

Conversation

emilbon99 commented Jun 14, 2024

vercel bot commented Jun 14, 2024 • edited Loading

codecov bot commented Jun 14, 2024 • edited Loading

Codecov Report

LeonLiur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Jun 14, 2024 •

edited

Loading

codecov bot commented Jun 14, 2024 •

edited

Loading