Pjdotson/sy 775 ontology ungrouping several folders at the same time causes #652
Conversation
Synnax 23.0 RC
…-opc-ua-documentation-improvements [docs] OPC UA documentation Improvements
…y-ungrouping-several-folders-at-the-same-time-causes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc #652 +/- ##
==========================================
+ Coverage 51.67% 51.83% +0.15%
==========================================
Files 1040 1040
Lines 78615 78658 +43
Branches 3249 3249
==========================================
+ Hits 40628 40773 +145
+ Misses 37001 36899 -102
Partials 986 986
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -81,6 +81,11 @@ const ungroupSelection = async ({ | |||
| state, | |||
| }: Ontology.TreeContextMenuProps): Promise<void> => { | |||
| if (selection.parent == null) return; | |||
| selection.resources.sort((a, b) => { | |||
There was a problem hiding this comment.
@pjdotson Can you explain how this fixes the problem?
There was a problem hiding this comment.
The only issue I could find was nested groups disappearing when ungrouping so if Group B is in Group A, ungrouping Group A first would not remove items originally in Group B from the tree. Ungrouping deeper groups first fixed that problem.
pjdotson
deleted the
pjdotson/sy-775-ontology-ungrouping-several-folders-at-the-same-time-causes
branch
Fix Pull Request Template
Key Information
Description
Prevented an issue where some items are removed from the subgroup when ungrouping by always ungrouping the most deeply nested group first.
Basic Readiness Checklist
Manual QA Additions
with necessary manual QA steps to test my change.