[cesium] - code cleanup #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc #712 +/- ##
==========================================
- Coverage 51.76% 51.23% -0.54%
==========================================
Files 1049 1049
Lines 79587 80501 +914
Branches 3319 3289 -30
==========================================
+ Hits 41201 41243 +42
- Misses 37386 38259 +873
+ Partials 1000 999 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lham42
approved these changes
Jul 12, 2024
emilbon99
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pull Request Template
Key Information
Interface changes
Added a SetAuthority method to cesium/writer – setAuthority is currently in use by the console (aether), but is not tested by any client or by cesium.
Description
Added test cases where lacking
Basic Readiness Checklist
Manual QA Additions
with necessary manual QA steps to test my change.