Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eislam/sy 953 cpp client review #724

Merged
merged 12 commits into from
Jul 20, 2024
Merged

Eislam/sy 953 cpp client review #724

merged 12 commits into from
Jul 20, 2024

Conversation

Lham42
Copy link
Contributor

@Lham42 Lham42 commented Jul 14, 2024

Fix Pull Request Template

Key Information

Description

Do not review yet. Opening to leave comments.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 6:29pm

Copy link
Contributor

@emilbon99 emilbon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilbon99
Copy link
Contributor

@Lham42 CPP test cases do not pass.

@Lham42 Lham42 merged commit 7248015 into rc Jul 20, 2024
28 checks passed
@pjdotson pjdotson deleted the eislam/sy-953-cpp-client-review branch July 25, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants