[aspen] - fixed issues with concurrent modification of cluster store

[emilbon99]

Fix Pull Request Template

Key Information

• Linear Issue: SY-1075

Description

Fixes an issue where the aspen store that holds information about a cluster concurrently reads and writes from a map. Adjusts the implementation of PeekState in x/go/store to hold a mutex until it is released.

Basic Readiness Checklist

• I have performed a self-review of my code.
• I have added sufficient regression tests to cover the changes to CI.
• I have added relevant tests to cover the changes or exposing bugs.
• I have verified code coverage targets are met.

Additional Notes

• These changes deal with concurrency.
• These changes affect UI.

Manual QA Additions

• I have updated the Release Candidate template
  with necessary manual QA steps to test my change.

Reviewer Checklist

• Sufficient test coverage of new additions.
• Verified all steps in readiness checklists.
• UI changes have been tested.
• style and formatting is consistent.
• Reviewed any relevant changes to concurrent code for safety.
• Sufficient comments and clarity of code.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2024 6:25pm

[codecov]

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.34%. Comparing base (0d29c58) to head (94be57f).
Report is 2 commits behind head on rc.

Files	Patch %	Lines
aspen/internal/cluster/store/store.go	53.84%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               rc     #772      +/-   ##
==========================================
+ Coverage   47.31%   47.34%   +0.02%     
==========================================
  Files        1082     1082              
  Lines       65734    65757      +23     
  Branches     3483     3483              
==========================================
+ Hits        31103    31133      +30     
+ Misses      33603    33596       -7     
  Partials     1028     1028              

Flag	Coverage Δ
aspen	50.47% <81.81%> (+0.32%)	⬆️
cesium	75.32% <ø> (-0.05%)	⬇️
clientpy	81.97% <ø> (ø)
clientts	77.61% <ø> (ø)
gox	59.17% <ø> (ø)
synnax	28.73% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.