SY-1038 Import / Export Schematic Improvements #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed logic for download schematic to a separate hook
…ng multiple files
…ed tooltip to button
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc #775 +/- ##
==========================================
+ Coverage 47.26% 47.40% +0.13%
==========================================
Files 1075 1082 +7
Lines 64914 65835 +921
Branches 3441 3486 +45
==========================================
+ Hits 30679 31206 +527
- Misses 33229 33600 +371
- Partials 1006 1029 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…to right-hand side of toolbar
…8-meaningful-error-when-importing-an-existing-schematic
emilbon99
approved these changes
Sep 1, 2024
Lham42
approved these changes
Sep 1, 2024
pjdotson
deleted the
sy-1038-meaningful-error-when-importing-an-existing-schematic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pull Request Template
Key Information
Description
Various improvements to importing / exporting a schematic, including an export button on the visualization toolbar, fixed file drag-and-drop, and better error catching.
IMPORTANT NOTE: I added a
namefield to the schematic state that tracks the name of the schematic. However, migrations from previous versions will not migrate over the new names to the state, instead giving it the name "New Schematic" in the store state.Basic Readiness Checklist
Additional Notes
Manual QA Additions
with necessary manual QA steps to test my change.
Reviewer Checklist