Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluto - Minor Select.Multiple Remove Fix #777

Merged

Conversation

emilbon99
Copy link
Contributor

@emilbon99 emilbon99 commented Aug 17, 2024

Fix Pull Request Template

Key Information

Description

Minor fix that addresses a bug when you remove a tag from a Select.Multiple and it removes the wrong item.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

Copy link

vercel bot commented Aug 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 6:26pm

@emilbon99 emilbon99 merged commit 9c6e484 into rc Aug 17, 2024
32 checks passed
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.35%. Comparing base (85907ab) to head (1f4915e).
Report is 2 commits behind head on rc.

Additional details and impacted files
@@           Coverage Diff           @@
##               rc     #777   +/-   ##
=======================================
  Coverage   47.35%   47.35%           
=======================================
  Files        1082     1082           
  Lines       65767    65767           
  Branches     3483     3484    +1     
=======================================
  Hits        31141    31141           
  Misses      33601    33601           
  Partials     1025     1025           
Flag Coverage Δ
pluto 35.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pjdotson pjdotson deleted the sy-1089-pluto-fix-select-tag-close-removing-the-wrong-item branch September 4, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants