Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SY-1141 Remove Edit Range from Create Range Modal #803

Merged

Conversation

pjdotson
Copy link
Contributor

@pjdotson pjdotson commented Sep 3, 2024

Refactor Pull Request Template

Key Information

Description

Fix an issue with the context menu in the range toolbar. Removed logic for editing a range layout when you create a layout.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@pjdotson pjdotson self-assigned this Sep 3, 2024
@pjdotson pjdotson merged commit e26e6c1 into main Sep 13, 2024
34 checks passed
@pjdotson pjdotson deleted the sy-1141-remove-view-details-from-range-toolbar-context-menu branch September 13, 2024 19:21
pjdotson added a commit that referenced this pull request Sep 13, 2024
pjdotson added a commit that referenced this pull request Sep 13, 2024
@pjdotson pjdotson restored the sy-1141-remove-view-details-from-range-toolbar-context-menu branch September 13, 2024 19:40
@pjdotson pjdotson deleted the sy-1141-remove-view-details-from-range-toolbar-context-menu branch September 13, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants