SY-1098 Add Ability to Resize Most Schematic Symbols

[pjdotson]

Feature Pull Request Template

Key Information

• Linear Issue: SY-1098

Description

Added ability to resize (almost) any schematic symbols - buttons, switches, values, and setpoints still cannot be resized. Also refactored some code in relevant files.

NOTE: Previous versions of the schematic will have a scale of null, so the options for scaling them will not show up. I don't know a great way to fix this problem, and don't think it matters too much - all it means is that the elements created before this version gets released cannot be scaled. If someone wants to scale that element, they could delete it and replace it with a new one.

Basic Readiness Checklist

• I have performed a self-review of my code.
• I have added relevant tests to cover the changes to CI.
• I have updated user facing documentation accordingly.
• I have verified code coverage targets are met.

Migrations

• Console - I have ensured that previous versions of stored data structures are
  properly migrated to new formats.
• Server - I have ensured that previous versions of stored data structures are
  properly migrated to new formats.

Additional Notes

• These changes deal with concurrency.
• These changes affect UI.

Manual QA Additions

• I have updated the Release Candidate template
  with necessary manual QA steps to test my change.

Breaking Changes

Please list any breaking changes to public or internal packages.

Reviwer Checklist

• Sufficient test coverage of new additions.
• Verified all steps in the Readiness checklists.
• UI changes have been tested.
• Style and formatting is consistent.
• Reviewed any relevant changes to concurrent code for safety.
• Sufficient comments and clarity of code.
• Any additional documentation necessary for feature is provided and has been reviewed for clarity.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.45662% with 218 lines in your changes missing coverage. Please review.

Project coverage is 46.38%. Comparing base (5b391d8) to head (592e1c9).
Report is 52 commits behind head on rc.

Files with missing lines	Patch %	Lines
pluto/src/vis/schematic/Symbols.tsx	0.00%	55 Missing ⚠️
pluto/src/vis/light/aether/light.ts	0.00%	50 Missing and 1 partial ⚠️
pluto/src/vis/schematic/Forms.tsx	0.00%	43 Missing ⚠️
pluto/src/vis/schematic/primitives/Primitives.tsx	0.00%	26 Missing ⚠️
pluto/src/vis/light/use.ts	0.00%	22 Missing and 1 partial ⚠️
pluto/src/vis/schematic/registry.ts	0.00%	16 Missing ⚠️
pluto/src/pluto/aether/pluto.ts	0.00%	2 Missing ⚠️
pluto/src/vis/light/aether/index.ts	0.00%	0 Missing and 1 partial ⚠️
pluto/src/vis/light/index.ts	0.00%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##               rc     #813      +/-   ##
==========================================
- Coverage   46.48%   46.38%   -0.11%     
==========================================
  Files        1083     1090       +7     
  Lines       67600    67833     +233     
  Branches     3494     3514      +20     
==========================================
+ Hits        31424    31464      +40     
- Misses      35129    35316     +187     
- Partials     1047     1053       +6     

Flag	Coverage Δ
pluto	35.48% <0.45%> (-0.23%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emilbon99]

This generally looks ok. I think we need to make some other changes for this feature to be nice though. Label positions look strange when elements are larger. Take this rotary mixer for example. It's probably pretty common to want to make this thing pretty large. It looks strange to fill in the entire mixer when it is turned on. We should probably make it so you hook up a switch to turn the mixer on and off, then we can make it possible to hide and show the controls states on it, so then it becomes more of a 'static' element.

Also, if you can scale the element, you should also have the option to make the stroke width of the symbol larger or smaller.

[emilbon99]

Just looks kinda strange to have this massive, white rotary mixer on the screen

[emilbon99]

Even though you would probably want to have a rotary mixer that big on your P&ID

[emilbon99]

Approved, although I think we need to spend more time thinking about the larger implications of making sure this feature has a nice UX