Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SY 1198 Add driver flags to CLI Docs #817

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Conversation

Lham42
Copy link
Contributor

@Lham42 Lham42 commented Sep 9, 2024

Fix Pull Request Template

Key Information

Description

Updates docs with missing documentation about driver specific flags for server cli.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@emilbon99 emilbon99 merged commit 34f0afd into main Sep 11, 2024
25 of 26 checks passed
@emilbon99 emilbon99 deleted the sy-1198-cli-ref-driver-flags branch September 11, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants