Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SY 1129 allow ni channels to be enabled and disabled #818

Merged
merged 11 commits into from
Sep 13, 2024
Merged

SY 1129 allow ni channels to be enabled and disabled #818

merged 11 commits into from
Sep 13, 2024

Conversation

Lham42
Copy link
Contributor

@Lham42 Lham42 commented Sep 9, 2024

Fix Pull Request Template

Key Information

Description

This pr fixes the issue where, if an ni channel is disabled, it still writes to the channel on the server.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@Lham42 Lham42 changed the base branch from main to rc September 9, 2024 18:02
@Lham42 Lham42 changed the title SY 1129 allow ni channels to be enabled and dsiabled SY 1129 allow ni channels to be enabled and disabled Sep 9, 2024
emilbon99
emilbon99 requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@emilbon99 emilbon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that this works? I think some of the if statements are backwards. Maybe I'm being ridiculous

driver/ni/digital_read.cpp Outdated Show resolved Hide resolved
driver/ni/digital_read.cpp Outdated Show resolved Hide resolved
driver/ni/digital_write.cpp Outdated Show resolved Hide resolved
driver/ni/digital_write.cpp Outdated
write_buffer, // data
&samplesWritten, // samples written
NULL))) {
1, // number of samples per channel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad formatting. Fix this

@Lham42 Lham42 merged commit d9bb763 into rc Sep 13, 2024
33 checks passed
@pjdotson pjdotson deleted the eislam/sy-1129-sy-disable-enable-ni-chan branch October 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilbon99 emilbon99 emilbon99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lham42 @emilbon99