Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SY-1218 documentation site breadcrumbs #831

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

emilbon99
Copy link
Contributor

@emilbon99 emilbon99 commented Sep 15, 2024

Feature Pull Request Template

Key Information

Description

Adds breadcrumbs as well as previous and next buttons to the documentation site.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have updated user facing documentation accordingly.
  • I have verified code coverage targets are met.

Migrations

  • Console - I have ensured that previous versions of stored data structures are
    properly migrated to new formats.
  • Server - I have ensured that previous versions of stored data structures are
    properly migrated to new formats.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Breaking Changes

Please list any breaking changes to public or internal packages.

Reviwer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in the Readiness checklists.
  • UI changes have been tested.
  • Style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.
  • Any additional documentation necessary for feature is provided and has been reviewed for clarity.

@emilbon99 emilbon99 changed the base branch from main to rc September 15, 2024 00:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 46.33%. Comparing base (f82b5ed) to head (1bd3722).

Files with missing lines Patch % Lines
pluto/src/breadcrumb/Breadcrumb.tsx 0.00% 56 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               rc     #831      +/-   ##
==========================================
- Coverage   46.35%   46.33%   -0.02%     
==========================================
  Files        1088     1088              
  Lines       67843    67883      +40     
  Branches     3513     3512       -1     
==========================================
+ Hits        31446    31452       +6     
- Misses      35344    35381      +37     
+ Partials     1053     1050       -3     
Flag Coverage Δ
aspen 50.51% <ø> (+0.17%) ⬆️
cesium 75.53% <ø> (ø)
clientpy 86.04% <ø> (ø)
clientts 61.35% <ø> (ø)
pluto 35.34% <0.00%> (-0.07%) ⬇️
synnax 28.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lham42 Lham42 changed the title Sy 1218 documentation site breadcrumbs SY-1218 documentation site breadcrumbs Sep 16, 2024
Copy link
Contributor

@Lham42 Lham42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Failing test is just broken api check

@Lham42 Lham42 merged commit 645a461 into rc Sep 16, 2024
33 of 34 checks passed
@pjdotson pjdotson deleted the sy-1218-documentation-site-breadcrumbs branch October 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants