SY-1221 Temporarily Focus a Layout #834
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## rc #834 +/- ##
==========================================
- Coverage 46.34% 46.33% -0.01%
==========================================
Files 1088 1089 +1
Lines 67885 68050 +165
Branches 3512 3503 -9
==========================================
+ Hits 31462 31532 +70
- Misses 35372 35472 +100
+ Partials 1051 1046 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Three things:
First, a minor problem - when you select on the tab selector bar to the right of all existing tabs, a context menu with only hard reload does not appear.
Second, I'm getting a bunch of errors in the devtools console when I play with windows and move them around (listed down below.
Third, I opened a bunch of tabs and then spammed cmd + W quickly (like three times). This caused the app to close before all of the tabs that were existing closed.
Warning: React does not recognize the borderShade prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase bordershade instead. If you accidentally passed it from a parent component, remove it from the DOM element
Warning: React does not recognize the endIcon prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase endicon instead. If you accidentally passed it from a parent component, remove it from the DOM element.
button
Warning: Received true for a non-boolean attribute visible.
If you want to write it to the DOM, pass a string instead: visible="true" or visible={value.toString()}.
Warning: Received false for a non-boolean attribute focused.
If you want to write it to the DOM, pass a string instead: focused="false" or focused={value.toString()}.
If you used to conditionally omit it with focused={condition && value}, pass focused={condition ? value : undefined} instead.
Feature Pull Request Template
Key Information
Description
Allows the user to temporarily focus a layout to make it occupy a larger portion of the screen.
Basic Readiness Checklist
Migrations
properly migrated to new formats.
properly migrated to new formats.
Additional Notes
Manual QA Additions
with necessary manual QA steps to test my change.
Breaking Changes
Please list any breaking changes to public or internal packages.
Reviwer Checklist