Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] - OPC UA boolean node support #875

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

Lham42
Copy link
Contributor

@Lham42 Lham42 commented Oct 17, 2024

Feature Pull Request Template

Key Information

Description

This PR adds a check for nodes of boolean type and handles data from that node as an uint8 internally.

Basic Readiness

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have needed QA steps to the release
    candidate
    template that cover these changes.
  • I have updated in-code documentation to reflect the changes.
  • I have updated user-facing documentation to reflect the changes.

Backwards Compatibility

The following makes sure that this feature does not break backwards compatability.

Data Structures

  • Server - I have ensured that previous versions of stored data structures are
    properly migrated to new formats.
  • Console - I have ensured that previous versions of stored data structures are
    properly migrated to new formats.

API Changes

  • Server - The server API is backwards-compatible
  • The following client APIs are backwards-compatible:
    • C++
    • TypeScript
    • Python

Breaking Changes

If anything in this section is not true, please list all breaking changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.78%. Comparing base (274c1b7) to head (d9707be).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   45.79%   45.78%   -0.02%     
==========================================
  Files        1103     1103              
  Lines       69894    69894              
  Branches     3551     3551              
==========================================
- Hits        32011    32002       -9     
- Misses      36828    36836       +8     
- Partials     1055     1056       +1     
Flag Coverage Δ
clientpy 86.04% <ø> (ø)
clientts 62.90% <ø> (ø)
synnax 28.86% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@emilbon99 emilbon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lham42 Lham42 merged commit 6f09534 into main Oct 17, 2024
31 checks passed
@pjdotson pjdotson deleted the sy-1384-boolean-support-opc-ua-tasks branch October 18, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants