Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ops/console] change runner for console deployment to macos-latest #883

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Lham42
Copy link
Contributor

@Lham42 Lham42 commented Oct 21, 2024

Feature Pull Request Template

Key Information

  • Linear Issue: SY-#

Description

Please write a short (2-3 sentence) description describing the changes.

Basic Readiness

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have needed QA steps to the release
    candidate
    template that cover these changes.
  • I have updated in-code documentation to reflect the changes.
  • I have updated user-facing documentation to reflect the changes.

Backwards Compatibility

The following makes sure that this feature does not break backwards compatability.

Data Structures

  • Server - I have ensured that previous versions of stored data structures are
    properly migrated to new formats.
  • Console - I have ensured that previous versions of stored data structures are
    properly migrated to new formats.

API Changes

  • Server - The server API is backwards-compatible
  • The following client APIs are backwards-compatible:
    • C++
    • TypeScript
    • Python

Breaking Changes

If anything in this section is not true, please list all breaking changes.

Copy link
Contributor

@pjdotson pjdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's watch and make sure Console deploy also works on push.

@Lham42 Lham42 merged commit f7fc920 into rc Oct 30, 2024
32 checks passed
@emilbon99 emilbon99 deleted the sy-1393-change-to-macos-latest-in-github-workflows branch November 12, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants