Sy 1390 add linting for type imports and arrows #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## rc #913 +/- ##
==========================================
+ Coverage 45.45% 45.49% +0.04%
==========================================
Files 1123 1124 +1
Lines 69125 68976 -149
Branches 3609 3603 -6
==========================================
- Hits 31418 31383 -35
+ Misses 36631 36516 -115
- Partials 1076 1077 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
deploy console still failing |
Lham42
added a commit
that referenced
this pull request
Nov 13, 2024
* Auto Update JSON File * [ops] - merged main and bumped RC version * Auto Update JSON File * Auto Update JSON File * Auto Update JSON File * Auto Update JSON File * SY-1416 fix issues with renaming multiple channels (#894) * [synnax] - fixed issues with renaming multiple channels of different types (virtual, free virtual, persisted) * [synnax] - improved naming * SY-1374 Fix Windows Channel Deletion Bug (#888) * [cesium] - test focusing on the happy path in delete * [ops] - added code to run windows tests on pushes on this branch * [ops] - added code to run windows tests on pushes on this branch * [ops] - changed order of testing on different OS * [ops] - changed order of testing on different OS * [cesium] - added one more test case for the case where no writer was ever opened * [cesium] fixed 3 bugs: 1. first cause of unable to delete is because index persist is not closed upon unary server close 2. second bug fix was after an unsuccessful unaryDB close, the db is marked as close even though the close failed, leading it be marked as closed although file handles are still open. 3. test cases asserting on opening a pre-existing DB in an FS does not close the DB. * [cesium] fixed flakey tests and windows List() fs * [cesium] fixed various leaking resources in tests and meta file handle * [server] removed blocking windows deletes * edited workflow files for aspen, cesium, and synnax * added back in quotes * ops(x): run x workflows on CI * fix file path * ops(go): remove fail-fast from go test ci workflows * [cesium] - addressed load race condition and fixed counter test * [x] - fixed a flakey test * [x] - fixed a flakey test * [x] - fixed a flakey test * [server] - skipped a failing test on windows * remove hyphens * [cesium] - concurrency patch for cesium DB * [cesium] - concurrency patch for cesium DB * [cesium] - changed db close mechanism so that closed is only marked as false when it fails in a nominal case * [cesium] - added comment explaining close conditions in unary close * [cesium] - added comment explaining db close --------- Co-authored-by: Synnax Windows EC2 <ebonilla@synnaxlabs.com> Co-authored-by: pjdotson <patrick@synnaxlabs.com> * SY-1453 Add Scientific and Engineering Notation to Schematic Values (#909) * [driver/labjack] move open call to constructor to shift work from start to configure * checkpoint * checkpoint * got notation working * formatting * move value telem form to two lines --------- Co-authored-by: Elham Islam <elham@synnaxlabs.com> * SY-1467 Labjack reconnect/disconnect (#907) * [driver/labjack] move open call to constructor to shift work from start to configure * [driver/labjack] global map for serial nums and handles * [HOTFIX] SY-1441 Update NI channel config for the python client (#896) * [client/py/ni] update ni channel config on python * [ops] bump py client version * [ops] bump py client version * [client/py] update ni tests * [client/py] - added default device check to NI * [client/py] - remove unused imports and formattting --------- Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> * [driver/labjack] append last 4 digits of ser number to dev name * [console] - fixed issues with task dialog flashing (#900) * [console] - fixed issues with task dialog flashing * [console] - rollback windows gen schema * Sy 1461 fix issues with improper window shutdown throwing errors (#901) * [console] - fixed issues with task dialog flashing * [console] - updated various layout hooks to tolerate delayed main window closure * [console] - updated store to disable debug * [console] - rollback windows gen schema * [ops] version bumps * [console] - added aliases to labjack port selection (#905) * [driver/labjack] refactor open for writer as well * SY-1435 Fix Add to New Plot on Line Plot Range Highlight (#899) * fix open new plot on range highlight * ops: bump version * [console] - updated windows schema to match the one one main * SY-1444 Fix Taring on Multiple Channels (#898) * [driver/labjack] create device manager * [client/py] - added type coersion for primitive non-string values in … (#903) * [client/py] - added type coersion for primitive non-string values in range KV * [client/py] - updated range kv to accept any stringer * [pluto] - improved value font sizing and spacing (#902) * [pluto] - improved value font sizing and spacing * [pluto] - updated value positioning * [pluto] - updated value text positioning and cnsolidated units level * [pluto] - adjusted value positioning to smoothly handle negatives * [ops] bump pluto version * [driver/labjack] format code * [ops] bump drift version * [driver/labjack] fix handling disconnected devices while write/read tasks are actively running * [console] missed merge conflict * [console] accepted wrong changes * [driver/labjack] remove commented out code * [driver/labjack] add other read errors that are caused by disconnect * [driver/labjack] change error sent * [driver/labjack] format code --------- Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> Co-authored-by: Patrick Dotson <123601024+pjdotson@users.noreply.github.com> * Auto Update JSON File * SY-1365 protect main branch but allow auto pushes from workflows (#911) * [ops] use deploy key to checkout code so github runner can push to main * [ops] remove fake param * [ops] - updated dependencies (#912) * Auto Update JSON File * SY-1486 Improve Schematic Connection Lines (#910) * Auto Update JSON File * SY-1390 ESLint New Configuration (#913) * Auto Update JSON File * [console] - fixed LabJack port indices (#917) * [console] - fixed LabJack port indices * [console] - reverted default parameter in LabJack write task * [console] - fixed LabJack DI ports * Sy 1403 ni scanner toggle on/off from command palette (#916) * [driver/ni] add device mutex for scanner * [driver/ni] undo mutex * [driver/ni] white space * [driver/ni] ws * [console] - implemented NI task toggling * [driver] verify can disable scanner * [driver] first join thread before releasing ni handles * [console] invert scanner toggle message --------- Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> * [drift/tauri] - fixed logical and physical position calculations (#919) * SY-1442 v.033, v0.34 Release Notes (#920) --------- Co-authored-by: pjdotson <pjdotson@users.noreply.github.com> Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> Co-authored-by: emilbon99 <emilbon99@users.noreply.github.com> Co-authored-by: pjdotson <patrick@synnaxlabs.com> Co-authored-by: Leo Liu <50342884+LeonLiur@users.noreply.github.com> Co-authored-by: Synnax Windows EC2 <ebonilla@synnaxlabs.com> Co-authored-by: Patrick Dotson <123601024+pjdotson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Pull Request Template
Key Information
Description
Added new rules for linting to keep formatting consistent, including needing type in front of all imports imported as a type, and preferring arrow call backs.
Basic Readiness
Backwards Compatibility
The following makes sure that this feature does not break backwards compatibility.
Data Structures
API Changes
Breaking Changes
If anything in this section is not true, please list all breaking changes.