-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synnax v0.34.0 RC #914
Synnax v0.34.0 RC #914
Conversation
* [synnax] - fixed issues with renaming multiple channels of different types (virtual, free virtual, persisted) * [synnax] - improved naming
* [cesium] - test focusing on the happy path in delete * [ops] - added code to run windows tests on pushes on this branch * [ops] - added code to run windows tests on pushes on this branch * [ops] - changed order of testing on different OS * [ops] - changed order of testing on different OS * [cesium] - added one more test case for the case where no writer was ever opened * [cesium] fixed 3 bugs: 1. first cause of unable to delete is because index persist is not closed upon unary server close 2. second bug fix was after an unsuccessful unaryDB close, the db is marked as close even though the close failed, leading it be marked as closed although file handles are still open. 3. test cases asserting on opening a pre-existing DB in an FS does not close the DB. * [cesium] fixed flakey tests and windows List() fs * [cesium] fixed various leaking resources in tests and meta file handle * [server] removed blocking windows deletes * edited workflow files for aspen, cesium, and synnax * added back in quotes * ops(x): run x workflows on CI * fix file path * ops(go): remove fail-fast from go test ci workflows * [cesium] - addressed load race condition and fixed counter test * [x] - fixed a flakey test * [x] - fixed a flakey test * [x] - fixed a flakey test * [server] - skipped a failing test on windows * remove hyphens * [cesium] - concurrency patch for cesium DB * [cesium] - concurrency patch for cesium DB * [cesium] - changed db close mechanism so that closed is only marked as false when it fails in a nominal case * [cesium] - added comment explaining close conditions in unary close * [cesium] - added comment explaining db close --------- Co-authored-by: Synnax Windows EC2 <ebonilla@synnaxlabs.com> Co-authored-by: pjdotson <patrick@synnaxlabs.com>
…909) * [driver/labjack] move open call to constructor to shift work from start to configure * checkpoint * checkpoint * got notation working * formatting * move value telem form to two lines --------- Co-authored-by: Elham Islam <elham@synnaxlabs.com>
* [driver/labjack] move open call to constructor to shift work from start to configure * [driver/labjack] global map for serial nums and handles * [HOTFIX] SY-1441 Update NI channel config for the python client (#896) * [client/py/ni] update ni channel config on python * [ops] bump py client version * [ops] bump py client version * [client/py] update ni tests * [client/py] - added default device check to NI * [client/py] - remove unused imports and formattting --------- Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> * [driver/labjack] append last 4 digits of ser number to dev name * [console] - fixed issues with task dialog flashing (#900) * [console] - fixed issues with task dialog flashing * [console] - rollback windows gen schema * Sy 1461 fix issues with improper window shutdown throwing errors (#901) * [console] - fixed issues with task dialog flashing * [console] - updated various layout hooks to tolerate delayed main window closure * [console] - updated store to disable debug * [console] - rollback windows gen schema * [ops] version bumps * [console] - added aliases to labjack port selection (#905) * [driver/labjack] refactor open for writer as well * SY-1435 Fix Add to New Plot on Line Plot Range Highlight (#899) * fix open new plot on range highlight * ops: bump version * [console] - updated windows schema to match the one one main * SY-1444 Fix Taring on Multiple Channels (#898) * [driver/labjack] create device manager * [client/py] - added type coersion for primitive non-string values in … (#903) * [client/py] - added type coersion for primitive non-string values in range KV * [client/py] - updated range kv to accept any stringer * [pluto] - improved value font sizing and spacing (#902) * [pluto] - improved value font sizing and spacing * [pluto] - updated value positioning * [pluto] - updated value text positioning and cnsolidated units level * [pluto] - adjusted value positioning to smoothly handle negatives * [ops] bump pluto version * [driver/labjack] format code * [ops] bump drift version * [driver/labjack] fix handling disconnected devices while write/read tasks are actively running * [console] missed merge conflict * [console] accepted wrong changes * [driver/labjack] remove commented out code * [driver/labjack] add other read errors that are caused by disconnect * [driver/labjack] change error sent * [driver/labjack] format code --------- Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com> Co-authored-by: Patrick Dotson <123601024+pjdotson@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
+ Coverage 45.47% 45.52% +0.04%
==========================================
Files 1121 1124 +3
Lines 69098 68968 -130
Branches 3597 3604 +7
==========================================
- Hits 31424 31395 -29
+ Misses 36607 36501 -106
- Partials 1067 1072 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* [ops] use deploy key to checkout code so github runner can push to main * [ops] remove fake param
* [console] - fixed LabJack port indices * [console] - reverted default parameter in LabJack write task * [console] - fixed LabJack DI ports
* [driver/ni] add device mutex for scanner * [driver/ni] undo mutex * [driver/ni] white space * [driver/ni] ws * [console] - implemented NI task toggling * [driver] verify can disable scanner * [driver] first join thread before releasing ni handles * [console] invert scanner toggle message --------- Co-authored-by: Emiliano Bonilla <56323762+emilbon99@users.noreply.github.com>
Release Candidate Pull Request
Key Information
QA Template
rc.md
template in this diff have been manually added to this pull request.Versioning
Version Consistency
I have verified that the following files have the same minor version number:
alamos/py
alamos/ts
client/py
client/ts
console
drift
freighter/py
freighter/ts
media
pluto
server
x/ts
package.json
fileVersion Conflicts
I have verified that, when released, the following packages will not conflict with any previously released packages:
alamos/py
alamos/ts
client/py
client/ts
console
drift
freighter/py
freighter/ts
media
pluto
server
x/ts
User Documentation
Content Changes
I have verified that user-facing documentation for each of the following services has been updated to match any changes in the release candidate:
reference/cluster
reference/concepts
reference/console
reference/control
reference/device-drivers/labjack
reference/device-drivers/ni
reference/device-drivers/opc-ua
reference/pluto
reference/python-client
reference/typescript-client
Examples
I have verified that code examples for each of the following services run correctly:
client/py
client/ts
examples/node
is up-to-datedrift/electron
drift/tauri
pluto
Release Notes
Console
Channels
I can successfully:
Clusters
I can successfully:
Devices
I can successfully:
Documentation
I can successfully:
Labels
I can successfully:
Layout
I can successfully:
Cmd + R
.Cmd + W
.Cmd + F
.Cmd + O
.Line Plots
I can successfully:
Logs
I can successfully:
Ontology
I can successfully:
Permissions
I can successfully:
Ranges
I can successfully:
Schematics
I can successfully:
Tasks
I can successfully:
Users
I can successfully:
Workspaces
I can successfully:
Version
I can successfully:
Driver
General
I can successfully:
Ctrl + C
) without errors from the driver routine.LabJack
I can successfully:
NI
I can successfully:
OPC UA
I can successfully: