Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SY-1375 Run CI on Windows and macOS #918

Open
wants to merge 70 commits into
base: rc
Choose a base branch
from

Conversation

pjdotson
Copy link
Contributor

Issue Pull Request

Key Information

Description

  • Run CI on Windows and macOS for most projects
  • Better diff filtering to decide if CI tests need to be run
  • Add a linting check in CI for TypeScript projects
  • Add a formatting check in CI for Go projects
  • Remove code for TypeScript client API generation
  • Update dependencies for alamos/py and freighter/integration

NOTE: The following projects are still only run on Linux because their CI tests need to access a local Linux Docker image:

  • client/cpp
  • client/py
  • client/ts
  • freighter/py
  • freighter/ts

SY-1377 lists these and a few other CI improvements that need to be made.

Basic Readiness

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have added needed QA steps to the release candidate template that cover these changes.
  • I have updated in-code documentation to reflect the changes.
  • I have updated user-facing documentation to reflect the changes.

Backwards Compatibility

Data Structures

I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:

  • Server
  • Console

API Changes

The following projects have backwards-compatible APIs:

  • Python Client
  • Server
  • TypeScript Client

Breaking Changes

@pjdotson pjdotson self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant