Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SY-1489 Loading Indicator on Task Toolbar #923

Open
wants to merge 9 commits into
base: rc
Choose a base branch
from

Conversation

pjdotson
Copy link
Contributor

Issue Pull Request

Key Information

Description

TypeScript Client

  • Add Task Command Observable
    Pluto
  • Add debounced loading icon for buttons
    Console
  • Added loading indicator to the task toolbars that start loading whenever a command to start or stop a task is sent.

Basic Readiness

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have added needed QA steps to the release candidate template that cover these changes.
  • I have updated in-code documentation to reflect the changes.
  • I have updated user-facing documentation to reflect the changes.

Backwards Compatibility

Data Structures

I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:

  • Server
  • Console

API Changes

The following projects have backwards-compatible APIs:

  • Python Client
  • Server
  • TypeScript Client

@pjdotson pjdotson added pluto Pluto UI components related ts-client console labels Nov 14, 2024
@pjdotson pjdotson self-assigned this Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.53%. Comparing base (646b34d) to head (368e478).
Report is 1 commits behind head on rc.

Files with missing lines Patch % Lines
client/ts/src/hardware/task/client.ts 7.69% 12 Missing ⚠️
client/ts/src/hardware/task/payload.ts 81.81% 2 Missing ⚠️
pluto/src/button/Button.tsx 90.00% 1 Missing ⚠️
pluto/src/status/Circle.tsx 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               rc     #923      +/-   ##
==========================================
+ Coverage   45.51%   45.53%   +0.01%     
==========================================
  Files        1124     1125       +1     
  Lines       68983    68995      +12     
  Branches     3604     3605       +1     
==========================================
+ Hits        31400    31416      +16     
+ Misses      36511    36505       -6     
- Partials     1072     1074       +2     
Flag Coverage Δ
clientts 62.10% <41.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console pluto Pluto UI components related ts-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants