Skip to content

Conversation

jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Sep 26, 2025

FIGMA

Description

Reference
Roadmap item

This PR implement the timed sheets and the "background payments" feature

  • Timed sheets
    • App update
    • Backup
    • Notifications
    • Quick pay
    • High balance
  • Background payments settings
  • Update notifications details and icon

Preview

backup_and_high_balance.webm
quick_pay_and_notifications.webm
mock_optional_update.webm
mock_critical_update.webm

QA Notes

OBS: The last timed ignored sheets is saved and recovered when recover the wallet (lost some time debugging until find out)

  • Optional update sheet
  • Critical update sheet
  • Fresh wallet> has balance > hasn't done backup > display Backup sheet
  • Notifications sheet
  • Quick pay sheet
  • High balance sheet
  • Change notifications settings > should reflect on background payments screen
  • background payments settings > hide payment details > should reflect on notifications

@jvsena42 jvsena42 self-assigned this Sep 26, 2025
@jvsena42
Copy link
Member Author

Refactoring in another branch to facilitate code review

@jvsena42 jvsena42 marked this pull request as draft October 10, 2025 18:16
@ovitrif
Copy link
Collaborator

ovitrif commented Oct 10, 2025

Refactoring in another branch to facilitate code review

Then let's merge this one 🎉 , shall we?!

It IS NOT breaking anything… just adding new functionality which needs a little extra polishing…

@jvsena42
Copy link
Member Author

Refactoring in another branch to facilitate code review

Then let's merge this one 🎉 , shall we?!

It IS NOT breaking anything… just ading new functionality that needs polishing…

I'm almost finishing, better wait

@jvsena42 jvsena42 mentioned this pull request Oct 10, 2025
7 tasks
@jvsena42 jvsena42 marked this pull request as ready for review October 13, 2025 12:08
@jvsena42
Copy link
Member Author

@ovitrif ovitrif self-requested a review October 13, 2025 12:42
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested:

  • Background payments settings > hide payment details 🟢
  • High balance sheet 🟢
  • Backup sheet 🟢
  • QuickPay sheet 🟢
  • Notifications sheet 🟢
  • Change notifications settings 🟠 - smaller animation glitch still present, but not a blocker:
bgPayGlitch.mp4

@piotr-iohk
Copy link
Collaborator

E2E tests successful: https://github.com/synonymdev/bitkit-android/actions/runs/18466779885

@jvsena42 jvsena42 merged commit 778e580 into master Oct 13, 2025
14 of 24 checks passed
@jvsena42 jvsena42 deleted the feat/time-sheet-polish branch October 13, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants