-
Notifications
You must be signed in to change notification settings - Fork 0
Timed sheets #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timed sheets #413
Conversation
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsIntroScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsIntroScreen.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsSettings.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsSettings.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsSettings.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsSettings.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsSettings.kt
Fixed
Show fixed
Hide fixed
app/src/main/java/to/bitkit/ui/settings/backgroundPayments/BackgroundPaymentsSettings.kt
Fixed
Show fixed
Hide fixed
Refactoring in another branch to facilitate code review |
Then let's merge this one 🎉 , shall we?! It IS NOT breaking anything… just adding new functionality which needs a little extra polishing… |
I'm almost finishing, better wait |
Move sheets to parent view
app/src/main/java/to/bitkit/ui/utils/RequestNotificationPermissions.kt
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested:
- Background payments settings > hide payment details 🟢
- High balance sheet 🟢
- Backup sheet 🟢
- QuickPay sheet 🟢
- Notifications sheet 🟢
- Change notifications settings 🟠 - smaller animation glitch still present, but not a blocker:
bgPayGlitch.mp4
E2E tests successful: https://github.com/synonymdev/bitkit-android/actions/runs/18466779885 |
FIGMA
Description
Reference
Roadmap item
This PR implement the timed sheets and the "background payments" feature
Preview
backup_and_high_balance.webm
quick_pay_and_notifications.webm
mock_optional_update.webm
mock_critical_update.webm
QA Notes
OBS: The last timed ignored sheets is saved and recovered when recover the wallet (lost some time debugging until find out)