Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(activity): wrong txId in some places #1903

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(activity): wrong txId in some places #1903

merged 1 commit into from
May 29, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 29, 2024

Description

Follow up to #1866. Fix needed because transfer activity item id refers to the funding tx and not the sweep tx.

Linked Issues/Tasks

Closes #1902

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr requested a review from limpbrains May 29, 2024 10:25
@pwltr pwltr merged commit 4192ea7 into master May 29, 2024
6 checks passed
@pwltr pwltr deleted the fix/activity-detail branch May 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tx indicated in "Open Block Explorer" is not the correct one
2 participants