Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): migrate swiper to new API #1917

Merged
merged 1 commit into from
Jun 11, 2024
Merged

refactor(ui): migrate swiper to new API #1917

merged 1 commit into from
Jun 11, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 30, 2024 •
edited
Loading

Description

Migrates SwipeToConfirm to new Gesture API.

Linked Issues/Tasks

Possibly fixes #1334

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-30.at.00.38.14.mp4

QA Notes

Make sure swiper still works as expected.

@pwltr pwltr merged commit 9fa27be into master Jun 11, 2024
6 checks passed
@pwltr pwltr deleted the fix/migrate-swiper branch June 11, 2024 15:29
@pwltr pwltr mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unresponsive Swipe to Pay
2 participants
@pwltr @limpbrains