Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(activity): refresh LDK after payment sent #1958

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jun 5, 2024

Description

Refresh LDK after pending payment has been claimed to update activity.

Linked Issues/Tasks

Closes #1929

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-05.at.19.26.54.mp4

@pwltr pwltr requested a review from coreyphillips June 5, 2024 17:25
@pwltr pwltr self-assigned this Jun 5, 2024
@pwltr pwltr merged commit 7d1fa01 into master Jun 5, 2024
6 checks passed
@pwltr pwltr deleted the fix/pending-payment branch June 5, 2024 19:04
@catch-21
Copy link
Contributor

Tested on v124
I've not had a slow enough payment to recreate this scenario. All payments today have been correctly added to activities list. Keep an eye on it in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LN payment can take manual refresh to recognise sent successful
3 participants