Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: beta migration #1975

Merged
merged 5 commits into from
Jun 10, 2024
Merged

feat: beta migration #1975

merged 5 commits into from
Jun 10, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Jun 10, 2024

Description

  • Add Beta migration UI
  • Add SlashAuth deprecation note
  • Remove (pending) transfer UI for channel closes

Since current beta shows transfer UI for mutual closes only we can just remove the pending time (we assume mutual close doesn't result in force close)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-10.at.13.52.13.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2024-06-10.at.13.59.02.mp4

QA Notes

The beta migration flow should show "transfer" screens only if user has open channels

@pwltr pwltr requested a review from limpbrains June 10, 2024 12:49
@pwltr pwltr force-pushed the feat/beta-migration branch from 225869e to 44c773f Compare June 10, 2024 13:01
@pwltr pwltr merged commit 152ebea into beta-release-118 Jun 10, 2024
5 of 6 checks passed
@pwltr pwltr deleted the feat/beta-migration branch June 11, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants