test: add testId hooks for E2E tests #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch-21
force-pushed
the
catch-21/testIds
branch
from
c40eac2 to
e848026
Compare
catch-21
changed the title
catch-21
force-pushed
the
catch-21/testIds
branch
2 times, most recently
from
3de36cc to
0027520
Compare
catch-21
force-pushed
the
catch-21/testIds
branch
from
0027520 to
a25af77
Compare
pwltr
reviewed
Dec 27, 2024
| @@ -119,6 +119,7 @@ const ReceiveAmount = ({ | |||
| {t('minimum')} | |||
| </Caption13Up> | |||
| <Money | |||
| testID="Minimum" | |||
There was a problem hiding this comment.
Looks good to me although these IDs should be unique across the app so maybe better to prefix with screen name "ReceiveAmountMinimum"
pwltr
reviewed
Dec 27, 2024
| @@ -172,7 +175,7 @@ const ReceiveConnect = ({ | |||
| <GradientView style={styles.container}> | |||
| <BottomSheetNavigationHeader title={t('receive_bitcoin')} /> | |||
| <View style={styles.content}> | |||
| <AmountToggle amount={amount} /> | |||
| <AmountToggle testID="Review" amount={amount} /> | |||
There was a problem hiding this comment.
Suggested change
| <AmountToggle testID="Review" amount={amount} /> | |
| <AmountToggle testID="ReceiveReviewAmount" amount={amount} /> |
There was a problem hiding this comment.
You're right, but I'm going with ReceiveConnectAmount
pwltr
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes and which issues are fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Linked Issues/Tasks
Add any links to GitHub issues or Asana tasks that are relevant to this pull request.
Type of change
Tests
Screenshot / Video
Insert relevant screenshot / recording
QA Notes
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce during the Bitkit testing session. You can also leave a video of the PR in action.