Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Empty scenes are wrongly serialized as null Issue #464 #465

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

ptc-tgamper
Copy link
Contributor

tinygltf.h - serialize empty scenes as empty json objects;
tester.cc

  • add respective test case
  • bring test cases in correct order
  • tag test case for light index with correct issue number and fix it to compare to deserialized model

tinygltf.h - serialize empty scenes as empty json objects; tester.cc - ad respective test case, bring test cases in correct order, tag test case for light index with correct issue number and fix it to compare to deserialozed model
@syoyo syoyo merged commit d32f1fb into syoyo:release Nov 23, 2023
8 checks passed
@syoyo
Copy link
Owner

syoyo commented Nov 23, 2023

Super cool! And good find! > issue number, light index tester

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants