return http response err (#477)

sysdiglabs · Jan 31, 2024 · 1e45b97 · 1e45b97
1 parent e474d10
commit 1e45b97
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/sysdig/internal/client/v2/posture_zones.go b/sysdig/internal/client/v2/posture_zones.go
@@ -13,33 +13,38 @@ const (
 
 type PostureZoneInterface interface {
 	Base
-	CreateOrUpdatePostureZone(ctx context.Context, z *PostureZoneRequest) (*PostureZone, error)
+	CreateOrUpdatePostureZone(ctx context.Context, z *PostureZoneRequest) (*PostureZone, string, error)
 	GetPostureZone(ctx context.Context, id int) (*PostureZone, error)
 	DeletePostureZone(ctx context.Context, id int) error
 }
 
-func (client *Client) CreateOrUpdatePostureZone(ctx context.Context, r *PostureZoneRequest) (*PostureZone, error) {
+func (client *Client) CreateOrUpdatePostureZone(ctx context.Context, r *PostureZoneRequest) (*PostureZone, string, error) {
 	if r.ID == "" {
 		r.ID = "0"
 	}
 
 	payload, err := Marshal(r)
 	if err != nil {
-		return nil, err
+		return nil, "", err
 	}
 
 	response, err := client.requester.Request(ctx, http.MethodPost, client.createZoneURL(), payload)
 	if err != nil {
-		return nil, err
+		return nil, "", err
 	}
 	defer response.Body.Close()
 
+	if response.StatusCode != http.StatusOK && response.StatusCode != http.StatusCreated && response.StatusCode != http.StatusAccepted {
+		errStatus, err := client.ErrorAndStatusFromResponse(response)
+		return nil, errStatus, err
+	}
+
 	wrapper, err := Unmarshal[PostureZoneResponse](response.Body)
 	if err != nil {
-		return nil, err
+		return nil, "", err
 	}
 
-	return &wrapper.Data, nil
+	return &wrapper.Data, "", nil
 }
 
 func (client *Client) GetPostureZone(ctx context.Context, id int) (*PostureZone, error) {

diff --git a/sysdig/resource_sysdig_secure_posture_zone.go b/sysdig/resource_sysdig_secure_posture_zone.go
@@ -138,9 +138,9 @@ func resourceCreateOrUpdatePostureZone(ctx context.Context, d *schema.ResourceDa
 		return diag.FromErr(err)
 	}
 
-	zone, err := zoneClient.CreateOrUpdatePostureZone(ctx, req)
+	zone, errStatus, err := zoneClient.CreateOrUpdatePostureZone(ctx, req)
 	if err != nil {
-		return diag.FromErr(err)
+		return diag.Errorf("Error creating resource: %s %s", errStatus, err)
 	}
 
 	d.SetId(zone.ID)