Skip to content

🌱 add check-conditions to e2e tests. #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 12, 2025

Conversation

guettli
Copy link
Collaborator

@guettli guettli commented Apr 3, 2025

Debugging e2e tests takes too much time.

This PR add continuous output to e2e tests, so that it is easier to understand what is going on.

Additionally logHCloudMachineStatus and logBareMetalHostStatus got refactored to not use By().

Result looks like this (which is diretly visible, without downloading the artifact):

 ≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡ <<< Start logging status
  --------------------------------------------------- Caph deployment ghcr.io/syself/caph-staging:pr-1579
  --------------------------------------------------- BareMetalHosts ghcr.io/syself/caph-staging:pr-1579
  BareMetalHost: bm-e2e-1670788 1670788
    ProvisioningState: provisioned
    Ready Condition: True  
  BareMetalHost: bm-e2e-1724024 1724024
    ProvisioningState: ensure-provisioned
    Error: connection refused error of SSH command ssh gave connection error
    Ready Condition: False StillProvisioning host is still provisioning - state "ensure-provisioned"
I0509 19:23:34.122640   16976 request.go:697] Waited for 1.159771193s due to client-side throttling, not priority and fairness, request: GET:https://127.0.0.1:37373/api/v1/serviceaccounts
I0509 19:23:44.122742   16976 request.go:697] Waited for 1.995051765s due to client-side throttling, not priority and fairness, request: GET:https://127.0.0.1:37373/apis/cluster.x-k8s.io/v1beta1/machines
  --------------------------------------------------- Unhealthy Conditions: 9
    ci14935553746-hvrhst hetznerbaremetalhosts bm-e2e-1724024 Condition ProvisionSucceeded=False StillProvisioning "host is still provisioning - state \"ensure-provisioned\"" (2m26s)
    ci14935553746-hvrhst hetznerbaremetalmachines ci14935553746-up3gah-md-1-x6nrg-nlgbh Condition HostReady=False StillProvisioning "host is still provisioning - state \"ensure-provisioned\"" (2m25s)
    ci14935553746-hvrhst machinedeployments ci14935553746-up3gah-md-1 Condition Available=False WaitingForAvailableMachines "Minimum availability requires 1 replicas, current 0 available" (14m39s)
    ci14935553746-hvrhst machinedeployments ci14935553746-up3gah-md-1 Condition MachineSetReady=False ScalingUp "Scaling up MachineSet to 1 replicas (actual 0)" (14m39s)
    ci14935553746-hvrhst machines ci14935553746-up3gah-md-1-x6nrg-nlgbh Condition InfrastructureReady=False StillProvisioning "host is still provisioning - state \"ensure-provisioned\"" (2m24s)
    ci14935553746-hvrhst machines ci14935553746-up3gah-md-1-x6nrg-nlgbh Condition NodeHealthy=False WaitingForNodeRef "" (14m40s)
    ci14935553746-hvrhst machines ci14935553746-up3gah-md-1-x6nrg-nlgbh Condition Ready=False StillProvisioning "1 of 2 completed" (7m26s)
    ci14935553746-hvrhst machinesets ci14935553746-up3gah-md-1-x6nrg Condition MachinesReady=False StillProvisioning @ Machine/ci14935553746-up3gah-md-1-x6nrg-nlgbh "0 of 1 completed" (7m25s)
    ci14935553746-hvrhst machinesets ci14935553746-up3gah-md-1-x6nrg Condition Resized=False ScalingUp "Scaling up MachineSet to 1 replicas (actual 0)" (14m39s)

@syself-bot syself-bot bot added size/XL Denotes a PR that changes 800-2000 lines, ignoring generated files. area/test Changes made in the test directory area/code Changes made in the code directory labels Apr 3, 2025
@guettli guettli requested a review from janiskemper May 9, 2025 18:44
Copy link
Contributor

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could maybe provide an example on what the difference in the output is

@guettli guettli merged commit 926a4c7 into main May 12, 2025
12 of 13 checks passed
@guettli guettli deleted the tg/add-check-conditions-to-continuous-log-during-e2e branch May 12, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory area/test Changes made in the test directory size/XL Denotes a PR that changes 800-2000 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants