Conversation
This migrates all $(shell,...) preprocessor calls in the toolchain
detection section to portable $(python,...) built-in from Kconfiglib,
eliminating POSIX shell dependency (2>/dev/null, ||, &&) and enables
Windows-compatible builds.
- CC_IS_EMCC/CLANG/GCC: use run() with sys.executable for shell-free
subprocess execution under the same Python interpreter
- COMPILER_TYPE: derive from CC_IS_* booleans via conditional
defaults, eliminating a redundant subprocess call entirely
- HAVE_EMCC: use in-process shutil.which() with no subprocess
- HAVE_SDL2: guard with shutil.which('pkg-config') to silently
return n when pkg-config is absent, then run() for the check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates all
$(shell,...)preprocessor calls in the toolchain detection section to portable$(python,...)built-in from Kconfiglib, eliminating POSIX shell dependency (2>/dev/null, ||, &&) and enables Windows-compatible builds.Summary by cubic
Replaced all$(shell,...) calls in toolchain detection with Kconfiglib’s $ (python,...) to remove the POSIX shell dependency and enable Windows builds. Simplified compiler type and dependency checks.
Written for commit 8615a31. Summary will update on new commits.