Merge pull request #213 from keytouch/master

procfs: Remove unnecessary cleanup on proc_create failure
sysprog21 · Jul 23, 2023 · 8172c03 · 8172c03
2 parents 433d031 + 5e2b7aa
commit 8172c03
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 4 deletions.
diff --git a/examples/procfs2.c b/examples/procfs2.c
@@ -77,7 +77,6 @@ static int __init procfs2_init(void)
 {
     our_proc_file = proc_create(PROCFS_NAME, 0644, NULL, &proc_file_fops);
     if (NULL == our_proc_file) {
-        proc_remove(our_proc_file);
         pr_alert("Error:Could not initialize /proc/%s\n", PROCFS_NAME);
         return -ENOMEM;
     }

diff --git a/examples/procfs3.c b/examples/procfs3.c
@@ -82,7 +82,6 @@ static int __init procfs3_init(void)
     our_proc_file = proc_create(PROCFS_ENTRY_FILENAME, 0644, NULL,
                                 &file_ops_4_our_proc_file);
     if (our_proc_file == NULL) {
-        remove_proc_entry(PROCFS_ENTRY_FILENAME, NULL);
         pr_debug("Error: Could not initialize /proc/%s\n",
                  PROCFS_ENTRY_FILENAME);
         return -ENOMEM;

diff --git a/examples/procfs4.c b/examples/procfs4.c
@@ -98,7 +98,6 @@ static int __init procfs4_init(void)
 
     entry = proc_create(PROC_NAME, 0, NULL, &my_file_ops);
     if (entry == NULL) {
-        remove_proc_entry(PROC_NAME, NULL);
         pr_debug("Error: Could not initialize /proc/%s\n", PROC_NAME);
         return -ENOMEM;
     }

diff --git a/examples/sleep.c b/examples/sleep.c
@@ -194,7 +194,6 @@ static int __init sleep_init(void)
     our_proc_file =
         proc_create(PROC_ENTRY_FILENAME, 0644, NULL, &file_ops_4_our_proc_file);
     if (our_proc_file == NULL) {
-        remove_proc_entry(PROC_ENTRY_FILENAME, NULL);
         pr_debug("Error: Could not initialize /proc/%s\n", PROC_ENTRY_FILENAME);
         return -ENOMEM;
     }