Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coastline tweaks #611

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Coastline tweaks #611

merged 2 commits into from
Dec 11, 2023

Conversation

systemed
Copy link
Owner

@systemed systemed commented Dec 11, 2023 •
edited
Loading

This is a small number of tweaks to address remaining coastline geometry issues as per #580:

  • Always run boost::geometry::correct before simplify_combine
  • Replace obsolete BOOST_GEOMETRY_INCLUDE_SELF_TURNS with BOOST_GEOMETRY_NO_ROBUSTNESS (which should be standard now anyway)
  • Add area filtering to the coastline layer below z12
  • Area filtering now looks at the size of each outer (not just the total size) as well as that of the inners
  • Remove special bay handling (Weird extra ocean shape #398)

@systemed systemed mentioned this pull request Dec 11, 2023
Open
@systemed systemed merged commit 34c356a into master Dec 11, 2023
5 checks passed
@systemed systemed deleted the coastline_tweaks branch December 11, 2023 20:38
@cldellow cldellow mentioned this pull request Dec 14, 2023
Merged
@systemed systemed mentioned this pull request Dec 26, 2023
Merged
@systemed systemed mentioned this pull request Mar 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@systemed