Smarter Lua detection in Makefile #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2024
Closed
|
Merged into v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting Lua is hard and currently our Makefile takes a fairly blunt approach of just checking some likely paths.
This PR makes it a little smarter by trying to find the Lua executable and using that to detect version/implementation (i.e. Lua or LuaJIT). We can then use this knowledge to inform the paths we look in.
(CMake of course does all this automatically. I could have pulled in pkg-config but would rather not add the extra dependency.)
Tested on Ubuntu 20.04 and Intel MacOS 10.14 with a couple of different Lua setups.
Fixes #633.