Fix reading bools from shapefiles #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we've ever handled shapefile bools correctly, and even what we did do slipped a little in 3.0. This should fix it such that bools are carried through correctly to the vector tile attributes.
DBF file format calls bools "logical values". Shapelib returns them as value 3 (==FTLogical). According to https://www.dbase.com/help/Design_Tables/IDH_TABLEDES_FIELD_TYPES.htm, truthy values can be T/t/Y/y, while falsey is F/f/N/n (sheesh). I have never seen anything other than "T" in the wild so that's all I'm handling here, but if that proves not to be the case, this PR is an aide-memoire for why!