attempt to fix workflow failures #758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub has deprecated the v2 version of the upload-artifact action: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ I didn't actually read the release notes, I'm just YOLOing into v4 and hoping that works. If it still fails, I'll investigate more.
|
D'oh, the workflow runs now, but fails due to #747. Reading the current docs for upload-artifact@v4, I think the YAML interface is the same, and so I expect it's safe to merge this. |
|
Closing in favour of #759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub has deprecated the v2 version of the upload-artifact action: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
Workflows automatically fail now due to using the outdated version - hence the failures on this documentation-only PR
I didn't actually read the release notes, I'm just YOLOing into v4 and hoping that works. If it still fails, I'll investigate more.