Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schleuder-web: bundle: various fixes #50

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

nevart
Copy link
Contributor

@nevart nevart commented May 21, 2024

See the commit messages for context and details.

nevart added 3 commits May 21, 2024 18:14
Otherwise, further bundle invocations might error out due to the Gemfile
relying on group-specific gems, which is not compatible with the current
Gemfile.lock, which is tracked in git upstream and which is not
group-aware.
Otherwise, bundle invocations might fail due to permission errors.
Before, due to the 'when' condition, gems have not been installed
correctly which would have lead to errors further on, if bundle was
invoked.
@nevart nevart added the bug Something isn't working label May 21, 2024
@nevart nevart self-assigned this May 21, 2024
@nevart
Copy link
Contributor Author

nevart commented May 21, 2024

CI failures seems unrelated to the changes made via this PR, but instead caused due to changes made in the Python requests lib: docker/docker-py#3256

@nevart nevart merged commit b959f48 into main May 21, 2024
2 of 4 checks passed
@nevart nevart deleted the schleuder-web-bundle-fixes branch May 21, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant