support tty #103
support tty #103
Conversation
TheSayOL
commented
May 7, 2024
TheSayOL
commented
- add tty support.
- add application busybox.
|
In path |
api/ruxos_posix_api/src/imp/ioctl.rs
Outdated
| debug!("sys_ioctl: tty TCGETS"); | ||
| let data = data as *const u8 as *mut Termios; | ||
| unsafe { | ||
| const ICRNL: usize = 0x100; |
There was a problem hiding this comment.
try to move safe code out of unsafe block.
There was a problem hiding this comment.
Some of these codes like ICRNL should be in C headers file.
| @@ -0,0 +1,63 @@ | |||
| //! Init | |||
There was a problem hiding this comment.
Add license information at the head of every source file.
There was a problem hiding this comment.
comment for license information should be like below:
/* Copyright (c) [2023] [Syswonder Community]
* [Ruxos] is licensed under Mulan PSL v2.
* You can use this software according to the terms and conditions of the Mulan PSL v2.
* You may obtain a copy of Mulan PSL v2 at:
* http://license.coscl.org.cn/MulanPSL2
* THIS SOFTWARE IS PROVIDED ON AN "AS IS" BASIS, WITHOUT WARRANTIES OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO NON-INFRINGEMENT, MERCHANTABILITY OR FIT FOR A PARTICULAR PURPOSE.
* See the Mulan PSL v2 for more details.
*/
modules/ruxhal/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[allow(unused)] |
There was a problem hiding this comment.
try use #[cfg(feature=...)] instead if possible.
| if flags != 0 { | ||
| return Err(LinuxError::EINVAL); | ||
| const GRND_NONBLOCK: c_int = 1; | ||
| const GRND_RANDOM: c_int = 2; |
There was a problem hiding this comment.
Put this two argument into header files. Import them like other C variables.
api/ruxos_posix_api/src/imp/ioctl.rs
Outdated
| @@ -27,6 +27,23 @@ pub struct ConsoleWinSize { | |||
| pub ws_ypixel: u16, | |||
| } | |||
|
|
|||
| const NCCS: usize = 19; | |||
| const ICANON: usize = 2; | |||
| const ECHO: usize = 8; | |||
There was a problem hiding this comment.
Put these three variables into C header files as well.
api/ruxos_posix_api/src/imp/ioctl.rs
Outdated
| c_cc: [c_uchar; NCCS], /* control characters */ | ||
| c_ispeed: c_uint, /* input speed */ | ||
| c_ospeed: c_uint, /* output speed */ | ||
| } |
api/ruxos_posix_api/src/imp/ioctl.rs
Outdated
|
|
||
| // .c_cflag = B38400 | CS8 | CREAD | HUPCL, | ||
|
|
||
| // .c_cc = INIT_C_CC, |
apps/c/busybox/axbuild.mk
Outdated
| ARGS = /bin/busybox,sh | ||
| ENVS = | ||
| V9P_PATH=${APP}/rootfs | ||
| # make run ARCH=aarch64 A=apps/c/busybox V9P=y MUSL=y LOG=debug |
apps/c/busybox/README.md
Outdated
There was a problem hiding this comment.
Also write a document for RuxOS-Book
| /// the operations a tty driver must implement. | ||
| /// passed by driver when registering itself. | ||
| #[derive(Debug)] | ||
| pub struct TtyDriverOps { |
There was a problem hiding this comment.
It is better to make it a trait.
crates/tty/src/driver.rs
Outdated
|
|
||
| /// driver's devices. | ||
| /// TODO: maybe use rwlock for dynamicly adding devices is better. | ||
| ttys: SpinNoIrq<Vec<Arc<TtyStruct>>>, |
| pub fn get_driver_by_index(index: usize) -> Option<Arc<TtyDriver>> { | ||
| let lock = ALL_DRIVERS.lock(); | ||
| for driver in lock.iter() { | ||
| if driver.index == index { |
There was a problem hiding this comment.
It seems that you can use index to get the driver directly? Why use an iter?
There was a problem hiding this comment.
It will lead to a type error if using an iter().find() instead of iter, as the iterator returns a reference rather than a variable with owership. So it uses .clone() to make it here correct.
TheSayOL
force-pushed
the
tty2
branch
3 times, most recently
from
396ac3e
to
b29ff0b
Compare
|
Is it OK to merge? @ken4647 I sort of forget the details. |
| pub fn get_driver_by_index(index: usize) -> Option<Arc<TtyDriver>> { | ||
| let lock = ALL_DRIVERS.lock(); | ||
| for driver in lock.iter() { | ||
| if driver.index == index { |
There was a problem hiding this comment.
It will lead to a type error if using an iter().find() instead of iter, as the iterator returns a reference rather than a variable with owership. So it uses .clone() to make it here correct.
