fix bug of sys_rt_sigaction, sys_poll, add sys_clock_nanosleep, sys_g… #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken4647
reviewed
Sep 14, 2024
api/ruxos_posix_api/src/imp/net.rs
Outdated
| @@ -21,6 +21,26 @@ use ruxnet::{TcpSocket, UdpSocket}; | |||
| use crate::ctypes; | |||
| use crate::utils::char_ptr_to_str; | |||
|
|
|||
| const SOL_SOCKET: i32 = 1; | |||
There was a problem hiding this comment.
Remove these definations and use ctyes::SO_BROADCAST instead to make sure they are consistent, if there is no special reason.
api/ruxos_posix_api/src/imp/net.rs
Outdated
| Socket::Tcp(_) => ctypes::SOCK_STREAM, | ||
| }, | ||
| SO_RCVLOWAT | SO_SNDLOWAT => 1, | ||
| SO_BROADCAST => 1, |
There was a problem hiding this comment.
Is there any reason not to merge SO_RCVLOWAT | SO_SNDLOWAT => 1, with SO_BROADCAST => 1,?
There was a problem hiding this comment.
I thinked it may not impl in same time in the future, but merge them is also ok.
api/ruxos_posix_api/src/imp/time.rs
Outdated
| ) -> c_int { | ||
| syscall_body!(sys_clock_nanosleep, { | ||
| unsafe { | ||
| if req.is_null() || (*req).tv_nsec < 0 || (*req).tv_nsec > 999999999 { |
There was a problem hiding this comment.
It would be better to replace 999999999 with const NANO_PER_SECOND = 1000000000 .
There was a problem hiding this comment.
and leave a comment here: )
ken4647
approved these changes
Sep 19, 2024
lhw2002426
added a commit
to lhw2002426/rukos
that referenced
this pull request
Sep 23, 2024
Merge pull request syswonder#139 from lhw2002426/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etsockopt