Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support signal and compelte setitimer, alarm, etc #14

Merged
merged 1 commit into from
Oct 26, 2023
Merged

support signal and compelte setitimer, alarm, etc #14

merged 1 commit into from
Oct 26, 2023

Conversation

AuYang261
Copy link
Contributor

No description provided.

@AuYang261 AuYang261 closed this Oct 10, 2023
@AuYang261 AuYang261 reopened this Oct 10, 2023
@AuYang261 AuYang261 closed this Oct 10, 2023
@AuYang261 AuYang261 reopened this Oct 10, 2023
coolyjg
coolyjg reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@coolyjg coolyjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please fix redis error. It seems that redis failed after this pr. I think you can create a new feature signal, and actually redis does not need this feature.
  • Some structure should be re-considered. k_sigaction and related structure should follow musl libc definition, and you can add new .h files in /include/

api/arceos_posix_api/src/imp/time.rs Outdated Show resolved Hide resolved
api/arceos_posix_api/src/imp/time.rs Outdated Show resolved Hide resolved
api/arceos_posix_api/src/imp/time.rs Show resolved Hide resolved
api/arceos_posix_api/src/imp/time.rs Outdated Show resolved Hide resolved
api/arceos_posix_api/src/imp/time.rs Outdated Show resolved Hide resolved
api/arceos_posix_api/src/imp/time.rs Outdated Show resolved Hide resolved
modules/axruntime/src/lib.rs Outdated Show resolved Hide resolved
modules/axruntime/src/signal.rs Outdated Show resolved Hide resolved
ulib/axlibc/c/signal.c Show resolved Hide resolved
@coolyjg coolyjg mentioned this pull request Oct 20, 2023
Merged
@AuYang261 AuYang261 marked this pull request as draft October 20, 2023 09:40
@AuYang261 AuYang261 marked this pull request as ready for review October 23, 2023 14:14
coolyjg
coolyjg reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@coolyjg coolyjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix these problems and I think it is ok to merge after fix and rebase

ulib/axlibc/src/unistd.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/unistd.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/unistd.rs Show resolved Hide resolved
ulib/axlibc/src/unistd.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/unistd.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/unistd.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/unistd.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/unistd.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/signal.rs Outdated Show resolved Hide resolved
ulib/axlibc/src/signal.rs Outdated Show resolved Hide resolved
@coolyjg coolyjg merged commit d1a2091 into syswonder:dev Oct 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolyjg coolyjg coolyjg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
I: RuxOS Initialization, Module Expan...
Development

Successfully merging this pull request may close these issues.
2 participants
@AuYang261 @coolyjg