Implemented riscv64 syscall support by modifying source code of opensbi and sbi-spec #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolyjg
reviewed
Mar 25, 2024
Sssssaltyfish
force-pushed
the
rv-syscall
branch
from
0dc2cf0
to
01feb0a
Compare
Closed
Sssssaltyfish
force-pushed
the
rv-syscall
branch
2 times, most recently
from
bfebcd3
to
efe73fc
Compare
Sssssaltyfish
force-pushed
the
rv-syscall
branch
from
95fceac
to
b44ca62
Compare
|
As all tests are passed and I've successfully done a clean build under riscv64 in my environment, I guess this PR is ready to be merged. Please tell me if there's any improvement I can do before rebasing it into one commit. |
coolyjg
reviewed
May 6, 2024
Besides, this commit also contains the following changes:
1. Added build suffix to musl to distinguish archs and modes.
2. Implemented prebuild hook so that opensbi would be cloned
while building under riscv64.
3. Fixed boot page table in riscv64 so that dtb won't cause
a page fault.
4. Updated github CI under riscv64.
coolyjg
approved these changes
May 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More precisely speaking, by having opensbi to pass unknown ecall to ruxos trap handler.
Note that due to the change of
[patch.crates.io]in /Cargo.toml, CIs won't pass unless we init submodules before tests in CI procedures. Also, I couldn't find acfg(target_arch = "riscv64")version of[patch.crates.io].Besides this modification, this PR does the following jobs:
opensbi and sbi-spec (used by sbi-rt used by ruxhal) are integrated via
git submodule.added 1000 to eid in sbi calls to distinguish sbi calls from posix sysacalls.
changed the default size of physical memory to 1G, as more would cause dtb page error in my environment.