Security: replace forgeable Hashids owner_token with server-side UUID#325
Open
ZigZagT wants to merge 2 commits intoszabodanika:masterfrom
Open
Security: replace forgeable Hashids owner_token with server-side UUID#325ZigZagT wants to merge 2 commits intoszabodanika:masterfrom
ZigZagT wants to merge 2 commits intoszabodanika:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #323 — the
owner_tokencookie used to skip burn-after-read counting was generated using unsalted Hashids encoding of two public values (expiry timestamp + pasta ID). Any reader could forge it and read burn-after-read pastas indefinitely.uuid::Uuid::new_v4()stored in a server-sideHashMap<u64, (String, u64)>verify_owner_token(token: &str, id: &str) -> boolunchangedDesign choices
std::sync::Mutex: map access is brief insert/lookup, no.awaitheld across lock.uuid = { version = "1", features = ["v4"] }dependency.Backwards compatibility
Zero breaking changes. No Pasta struct changes, no DB migration, no URL changes. Existing pastas have no map entry, so
verify_owner_tokenreturns false (same as expired token).Test plan
Test is designed to fail without the fix and pass with the fix using identical test code:
cargo testcargo testdocker run --rm -v $(pwd):/src -w /src deaddev/ubuntu:rust cargo test --bin microbin test_hashids_forged_token_rejected🤖 Generated with Claude Code