This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Disallow instruction with label operand in a bundle #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the error message now contains that function's name.
…s is an add of a label. Previously, this would compile but produce incorrect object code.
schoeberl
approved these changes
Nov 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling assembly, can no longer create a bundle where the first instruction uses a label operand, since it would need to be a long immediate instruction and therefore can't be part of a bundle. Fixes #15.
Tests for this change will be provided as a PR to the benchmark repository.
Also includes a change to the error message thrown in #14 to provide better information about the error. Instead of the old message:
it will throw the message: