another critical bugfix. Settings get wiped on certain conditions if …

…validation fails.....

MyCBZ/App.config

@@ -64,7 +64,7 @@
     <applicationSettings>
         <Win_CBZ.Win_CBZSettings>
             <setting name="Version" serializeAs="String">
-                <value>0.14.70b</value>
+                <value>0.14.71b</value>
             </setting>
             <setting name="RenamerPlaceholders" serializeAs="Xml">
                 <value>

MyCBZ/Exceptions/MetaDataValidationException.cs

@@ -18,5 +18,11 @@ public MetaDataValidationException(MetaDataEntry item, String message, bool show
             Item = item;
             RemoveEntry = removeEntry;
         }
+
+        public MetaDataValidationException(String key, String value, String message, bool showErrorDialog = false, bool removeEntry = false) : base(message, showErrorDialog)
+        {
+            Item = new MetaDataEntry(key, value);
+            RemoveEntry = removeEntry;
+        }
     }
 }

MyCBZ/Forms/MainForm.cs

@@ -2692,6 +2692,9 @@ private void SettingsToolStripMenuItem_Click(object sender, EventArgs e)
 
                 Win_CBZSettings.Default.ValidateTags = settingsDialog.ValidateTagsSetting;
                 Win_CBZSettings.Default.TagValidationIgnoreCase = settingsDialog.TagValidationIgnoreCase;
+            } else
+            {
+               //
             }
         }
 

MyCBZ/Forms/MainForm.resx

@@ -140,7 +140,7 @@
         AAEAAAD/////AQAAAAAAAAAMAgAAAFdTeXN0ZW0uV2luZG93cy5Gb3JtcywgVmVyc2lvbj00LjAuMC4w
         LCBDdWx0dXJlPW5ldXRyYWwsIFB1YmxpY0tleVRva2VuPWI3N2E1YzU2MTkzNGUwODkFAQAAACZTeXN0
         ZW0uV2luZG93cy5Gb3Jtcy5JbWFnZUxpc3RTdHJlYW1lcgEAAAAERGF0YQcCAgAAAAkDAAAADwMAAABu
-        CgAAAk1TRnQBSQFMAgEBAwEAAdABDgHQAQ4BEAEAARABAAT/AQkBAAj/AUIBTQE2AQQGAAE2AQQCAAEo
+        CgAAAk1TRnQBSQFMAgEBAwEAAfABDgHwAQ4BEAEAARABAAT/AQkBAAj/AUIBTQE2AQQGAAE2AQQCAAEo
         AwABQAMAARADAAEBAQABCAYAAQQYAAGAAgABgAMAAoABAAGAAwABgAEAAYABAAKAAgADwAEAAcAB3AHA
         AQAB8AHKAaYBAAEzBQABMwEAATMBAAEzAQACMwIAAxYBAAMcAQADIgEAAykBAANVAQADTQEAA0IBAAM5
         AQABgAF8Af8BAAJQAf8BAAGTAQAB1gEAAf8B7AHMAQABxgHWAe8BAAHWAucBAAGQAakBrQIAAf8BMwMA
@@ -198,7 +198,7 @@
         AAEAAAD/////AQAAAAAAAAAMAgAAAFdTeXN0ZW0uV2luZG93cy5Gb3JtcywgVmVyc2lvbj00LjAuMC4w
         LCBDdWx0dXJlPW5ldXRyYWwsIFB1YmxpY0tleVRva2VuPWI3N2E1YzU2MTkzNGUwODkFAQAAACZTeXN0
         ZW0uV2luZG93cy5Gb3Jtcy5JbWFnZUxpc3RTdHJlYW1lcgEAAAAERGF0YQcCAgAAAAkDAAAADwMAAABe
-        PgAAAk1TRnQBSQFMAgEBEQEAAdABDgHQAQ4BGAEAARgBAAT/ARkBAAj/AUIBTQE2BwABNgMAASgDAAFg
+        PgAAAk1TRnQBSQFMAgEBEQEAAfABDgHwAQ4BGAEAARgBAAT/ARkBAAj/AUIBTQE2BwABNgMAASgDAAFg
         AwABeAMAAQEBAAEYBgABh/8A/wD/AHgAAtQB1QMnNiUDJwPV3gADvQMlNr0DJQO+3gADvQMlEgAD/wHl
         AfMB9gG8AeoB8wG8AeoB8wHlAfMB9gP/EgADJQO+3gADvQMlDwAB9AH4AfkBUAHaAfQBAAHSAfoBAAHS
         AfoBAAHSAfoBAAHSAfoBUAHaAvQB+AH5DwADJQO+3gADvQMlDAAB+gL7AS4B1wH3AQAB0gH6AcwB7QL0
@@ -490,7 +490,7 @@ The Page with Type 'FrontCover' should be at index 1.
         AAEAAAD/////AQAAAAAAAAAMAgAAAFdTeXN0ZW0uV2luZG93cy5Gb3JtcywgVmVyc2lvbj00LjAuMC4w
         LCBDdWx0dXJlPW5ldXRyYWwsIFB1YmxpY0tleVRva2VuPWI3N2E1YzU2MTkzNGUwODkFAQAAACZTeXN0
         ZW0uV2luZG93cy5Gb3Jtcy5JbWFnZUxpc3RTdHJlYW1lcgEAAAAERGF0YQcCAgAAAAkDAAAADwMAAAAK
-        AwAAAk1TRnQBSQFMAgEBAgEAAUABDgFAAQ4BEAEAARABAAT/ARkBAAj/AUIBTQE2BwABNgMAASgDAAFA
+        AwAAAk1TRnQBSQFMAgEBAgEAAWABDgFgAQ4BEAEAARABAAT/ARkBAAj/AUIBTQE2BwABNgMAASgDAAFA
         AwABEAMAAQEBAAEYBgABDCEAA/cD2QPEA78D0gPtA/6lAAP+A7kDLA8lA38D/RIAA+cBUgFUAVUD+g8A
         A7gBtgK4bwAD+wOGBiUDSQOrA60DfwYlA0QD4wwAA+YDUAMlA30D+gYAA/0DtAMrAyUDumkAA/4DYwkl
         A5sGAAPfCSUDRAP9BgAD5wwlA0YD+gMAA7QMJQG2ArhmAAPUDCUDmwYAA98MJQN/A/4DAAPoAzUMJQN9
@@ -514,7 +514,7 @@ The Page with Type 'FrontCover' should be at index 1.
         AAEAAAD/////AQAAAAAAAAAMAgAAAFdTeXN0ZW0uV2luZG93cy5Gb3JtcywgVmVyc2lvbj00LjAuMC4w
         LCBDdWx0dXJlPW5ldXRyYWwsIFB1YmxpY0tleVRva2VuPWI3N2E1YzU2MTkzNGUwODkFAQAAACZTeXN0
         ZW0uV2luZG93cy5Gb3Jtcy5JbWFnZUxpc3RTdHJlYW1lcgEAAAAERGF0YQcCAgAAAAkDAAAADwMAAAAQ
-        DAAAAk1TRnQBSQFMAgEBBAEAAdgBDgHYAQ4BEAEAARABAAT/AQkBAAj/AUIBTQE2AQQGAAE2AQQCAAEo
+        DAAAAk1TRnQBSQFMAgEBBAEAAfgBDgH4AQ4BEAEAARABAAT/AQkBAAj/AUIBTQE2AQQGAAE2AQQCAAEo
         AwABQAMAASADAAEBAQABCAYAAQgYAAGAAgABgAMAAoABAAGAAwABgAEAAYABAAKAAgADwAEAAcAB3AHA
         AQAB8AHKAaYBAAEzBQABMwEAATMBAAEzAQACMwIAAxYBAAMcAQADIgEAAykBAANVAQADTQEAA0IBAAM5
         AQABgAF8Af8BAAJQAf8BAAGTAQAB1gEAAf8B7AHMAQABxgHWAe8BAAHWAucBAAGQAakBrQIAAf8BMwMA

MyCBZ/Forms/SettingsDialog.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Collections.Specialized;
@@ -8,7 +9,9 @@
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
+using System.Windows.Controls;
 using System.Windows.Forms;
+using Win_CBZ.Data;
 
 namespace Win_CBZ.Forms
 {
@@ -29,16 +32,26 @@ public SettingsDialog()
 
             if (Win_CBZSettings.Default.CustomDefaultProperties != null)
             {
-                CustomDefaultKeys.Lines = Win_CBZSettings.Default.CustomDefaultProperties.OfType<String>().ToArray();
+                NewDefaults = Win_CBZSettings.Default.CustomDefaultProperties.OfType<String>().ToArray();
             }
 
             if (Win_CBZSettings.Default.ValidKnownTags != null)
             {
-                ValidTags.Lines = Win_CBZSettings.Default.ValidKnownTags.OfType<String>().ToArray();
+                NewValidTagList = Win_CBZSettings.Default.ValidKnownTags.OfType<String>().ToArray();
             }
 
-            CheckBoxValidateTags.Checked = Win_CBZSettings.Default.ValidateTags;
-            CheckBoxTagValidationIgnoreCase.Checked = !Win_CBZSettings.Default.TagValidationIgnoreCase;
+            ValidateTagsSetting = Win_CBZSettings.Default.ValidateTags;
+            TagValidationIgnoreCase = Win_CBZSettings.Default.TagValidationIgnoreCase;
+
+            // ----------------------------------------
+
+            ValidTags.Lines = NewValidTagList;
+            CustomDefaultKeys.Lines = NewDefaults;
+
+            CheckBoxValidateTags.Checked = ValidateTagsSetting;
+            CheckBoxTagValidationIgnoreCase.Checked = !TagValidationIgnoreCase;
+
+            DialogResult = DialogResult.Cancel;
         }
 
         private void ButtonCancel_Click(object sender, EventArgs e)
@@ -61,6 +74,23 @@ private void SettingsDialog_FormClosing(object sender, FormClosingEventArgs e)
                     Program.ProjectModel.MetaData.MakeDefaultKeys(Program.ProjectModel.MetaData.CustomDefaultProperties);
 
                     Program.ProjectModel.MetaData.ValidateDefaults();
+
+                    if (CheckBoxValidateTags.Checked)
+                    {
+                        List<String> test = new List<String>(ValidTags.Lines);
+                        String[] duplicateTags = DataValidation.ValidateDuplicateStrings(test.ToArray());
+                        if (duplicateTags.Length > 0)
+                        {
+                            //ApplicationMessage.ShowWarning("Validateion Error! Duplicate Tags [" + duplicateTags.Select(r => r + ", ") + "] not allowed!", "Validation Error", ApplicationMessage.DialogType.MT_WARNING, ApplicationMessage.DialogButtons.MB_OK);
+                            MessageLogger.Instance.Log(LogMessageEvent.LOGMESSAGE_TYPE_WARNING, "Validateion Error! Duplicate Tags [" + String.Join(",", duplicateTags) + "] not allowed!");
+
+                            throw new MetaDataValidationException("", "", "Validateion Error! Duplicate Tags [" + String.Join(",", duplicateTags) + "] not allowed!");
+                        }
+                    }
+
+                    // -------------- DANGER!  All validation goes above this line --------------------
+
+
                     if (Win_CBZSettings.Default.CustomDefaultProperties != null)
                     {
                         Win_CBZSettings.Default.CustomDefaultProperties.Clear();
@@ -86,9 +116,10 @@ private void SettingsDialog_FormClosing(object sender, FormClosingEventArgs e)
                 }
                 catch (MetaDataValidationException mv)
                 {
+                    DialogResult = DialogResult.Cancel;
                     e.Cancel = true;
                     MessageLogger.Instance.Log(LogMessageEvent.LOGMESSAGE_TYPE_ERROR, mv.Message);
-                    ApplicationMessage.ShowException(mv);
+                    ApplicationMessage.ShowWarning(mv.Message, "Validation Error", ApplicationMessage.DialogType.MT_WARNING, ApplicationMessage.DialogButtons.MB_OK);
                 }
             }
         }

MyCBZ/Win_CBZSettings.settings

@@ -6,7 +6,7 @@
       <Value Profile="(Default)">%APPDATA%\CBZMage\Temp\</Value>
     </Setting>
     <Setting Name="Version" Type="System.String" Scope="Application">
-      <Value Profile="(Default)">0.14.70b</Value>
+      <Value Profile="(Default)">0.14.71b</Value>
     </Setting>
     <Setting Name="RenamerPlaceholders" Type="System.Collections.Specialized.StringCollection" Scope="Application">
       <Value Profile="(Default)">&lt;?xml version="1.0" encoding="utf-16"?&gt;

Readme.md

@@ -30,7 +30,7 @@ Microsoft Visual Studio [Community] 2022 (64-Bit)
 
 ## Latest Release
 
-v0.14.70b released!
+v0.14.71b released!
 
 ## Third party components
 

Win_CBZ-Setup/Win_CBZ-Setup.vdproj

@@ -434,15 +434,15 @@
         {
         "Name" = "8:Microsoft Visual Studio"
         "ProductName" = "8:Win_CBZ"
-        "ProductCode" = "8:{E5C5DFCD-821B-42BE-A467-F10EB6A6B89B}"
-        "PackageCode" = "8:{3137D366-6AE1-4C64-8793-3860CE383F47}"
+        "ProductCode" = "8:{88E93F51-F31F-4181-92C5-EBB0D109DB11}"
+        "PackageCode" = "8:{7C2B7900-5DB4-4AC3-AE55-FD0B31211593}"
         "UpgradeCode" = "8:{66FAEF81-1CAE-4971-9E0F-796310EFEA5E}"
         "AspNetVersion" = "8:4.0.30319.0"
         "RestartWWWService" = "11:FALSE"
         "RemovePreviousVersions" = "11:TRUE"
         "DetectNewerInstalledVersion" = "11:TRUE"
         "InstallAllUsers" = "11:FALSE"
-        "ProductVersion" = "8:0.14.70"
+        "ProductVersion" = "8:0.14.71"
         "Manufacturer" = "8:Trash_s0Ft"
         "ARPHELPTELEPHONE" = "8:"
         "ARPHELPLINK" = "8:"