Skip to content

Adding some aggregation endpoints #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

machakux
Copy link

@machakux machakux commented Oct 4, 2014

I was assuming a resources collection might accommodate multiple resource types, then resources can be classified by type through facility_code.

Examples:

/api/<facility_code>/values/region
/api/<facility_code>/count/region
/api/<facility_code>/sum/region/population_served

I would prefer to use endpoint instead of facility_code (i.e something like /api/waterpoints/values/region instead of /api/wp001/values/region) for the sake of consistency & prettier URLs but I haven't figured how to do that without an extra database query unless facility_code values are equal endpoints. Is there a more convenient way to resolve this or should I just assume there will be one resource type per instance?

@kynan
Copy link
Member

kynan commented Oct 4, 2014

I agree it would be nicer to use the endpoint rather than the facility_code. I don't have a good idea how to implement it though. You could potentially fire the get request through eve, however that requires to set up the right flask request context which I don't remember how to do. What you have is a reasonable start I think.

@dgorissen
Copy link
Member

Note wp001 is just something I made up. AFAIK this is completely arbitrary and there is no guidance or standard around what facility_code should be. In an ideal world this would be set by the administrative entity.

No reason we can't rename wp001 to something more friendly. Without any further information trying to come up with a scheme mapping onto is not worth it IMO.

@machakux
Copy link
Author

I have added endpoints for retrieving group difference, ratio and sum of product of two fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants