Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server event to update mismatched vehicle types list #1025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scullyy
Copy link

@Scullyy Scullyy commented Jan 17, 2025

  • Adds server event to update the mismatched vehicle types list, this removes the requirement to update the list every time you update your artifacts.
  • Moves mismatched types to server due to being required for the event to work, event needs to be server sided to prevent abuse.
  • Tested on b3258 with the latest artifacts and txAdmin version as of this PR and working.

Example usage:

TriggerEvent('txAdmin:menu:addMismatchedTypes', {
    caddy3 = 'automobile',
    trailersmall2 = 'trailer',
    scrap = 'automobile',
    tractor3 = 'automobile'
})

- Adds event to update the mismatched vehicle types list.
- Moves mismatched types to server.

Example usage:

```lua
TriggerEvent('txAdmin:menu:addMismatchedTypes', {
    caddy3 = 'automobile',
    trailersmall2 = 'trailer',
    scrap = 'automobile',
    tractor3 = 'automobile'
})
```
@Scullyy Scullyy requested a review from tabarra as a code owner January 17, 2025 21:16
@tabarra
Copy link
Owner

tabarra commented Feb 23, 2025

@Scullyy Thanks for the PR.

If the system is broken in txAdmin, the right thing is for it to be fixed in txAdmin instead of getting individual server owners to fix it themselves.

That being, said, I tried updating this using my old guide and something is very wrong.
The list of classes seem to now be 22 items long instead of just 7, as can be seen in the fivem docs, and using this list marks all 844 vehicles as divergent.
But furthermore, I tried spawning a vehicle from the list and the game didn't crash as it usually did.

Can someone that knows more about the game help me fix this issue? Is this still even an issue?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants