-
Notifications
You must be signed in to change notification settings - Fork 445
Add support for receiving "Customized Monthly" schedule intervals #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for parsing "Customized Monthly" schedules in the Tableau Server Client. The change handles a new monthly interval type that can be returned by the Tableau API.
- Added "Customized Monthly" as a valid monthly interval value
- Added test coverage for parsing customized monthly schedules
- Created test fixture for customized monthly schedule XML response
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tableauserverclient/models/interval_item.py | Added "Customized Monthly" to the list of valid monthly interval values |
| test/test_schedule.py | Added test case and test fixture constant for customized monthly schedule |
| test/assets/schedule_get_customized_monthly_id.xml | Added XML fixture representing a customized monthly schedule response |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jorwoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to recreate a server responding with "Customized Monthly", but I see no issues with adding it.
Add handling to recognize "Customized Monthly" as a possible interval type that can be returned for schedules.
Also add a test with a simulated xml response to confirm.
Fixes #1365