feat: support extensions api #1672
Conversation
jorwoods
commented
Oct 20, 2025
jorwoods
commented
- feat: List server extension settings
- feat: support updating server extension settings
- feat: enable retrieving site extension settings
- feat: support updating site settings
jorwoods
force-pushed
the
jorwoods/extensions
branch
from
ea7ba86 to
bcea6f4
Compare
|
I also added the new attributes as referenced in #1629, but do not have the .xsd file for the future release that will reflect those attributes so cannot verify the structure of what I have added. Please review the structure I had assumed based on that issue. |
|
thanks - I'll get one of the right engineers to review! |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for managing Tableau extensions settings at both server and site levels. The implementation includes new model classes for extensions configuration, API endpoints for retrieving and updating settings, and comprehensive test coverage.
Key changes:
- Added new model classes (
ExtensionsServer,ExtensionsSiteSettings,SafeExtension) to represent extension settings - Implemented
Extensionsendpoint with methods for getting and updating server and site-level extension settings - Added test coverage for all extension-related operations
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tableauserverclient/models/extensions_item.py | Defines data models for extensions server settings, site settings, and safe extensions |
| tableauserverclient/server/endpoint/extensions_endpoint.py | Implements API endpoint for managing extensions settings |
| tableauserverclient/server/request_factory.py | Adds request builders for extensions update operations |
| tableauserverclient/server/server.py | Integrates Extensions endpoint into Server class |
| tableauserverclient/server/endpoint/init.py | Exports Extensions endpoint |
| tableauserverclient/models/init.py | Exports extensions model classes |
| tableauserverclient/init.py | Adds extensions classes to public API |
| tableauserverclient/models/property_decorators.py | Adds Tuple import for type hints |
| test/test_extensions.py | Comprehensive test suite for extensions functionality |
| test/assets/extensions_site_settings.xml | Test fixture for site-level extension settings |
| test/assets/extensions_server_settings_true.xml | Test fixture for enabled server extensions |
| test/assets/extensions_server_settings_false.xml | Test fixture for disabled server extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jacksonlauren
left a comment
jacksonlauren
left a comment
There was a problem hiding this comment.
Thank you for this!! Looking great, just a few questions (mostly for Brian and team)
| @property | ||
| def use_default_setting(self) -> bool | None: | ||
| return self._use_default_setting | ||
|
|
||
| @use_default_setting.setter | ||
| @property_is_boolean | ||
| def use_default_setting(self, value: bool | None) -> None: | ||
| self._use_default_setting = value |
There was a problem hiding this comment.
I believe the useDefaultSetting setting is deprecated by the time new new trusted extensions settings come around - we can skip adding it I think! @bcantoni to confirm
There was a problem hiding this comment.
@jacksonlauren Sounds like we might need to keep this for as long as anything <3.27 is supported though.
There was a problem hiding this comment.
If I'm remembering correctly, it is fully unhooked from any client code - essentially a noop - and has been for some time now. Even though <3.27 has it in the API, there's not a need for anyone to use it.
I'll check with Brian though, I'm not sure when exactly that happened and if we still support versions of Tableau that would utilize useDefaultSetting in any way
| response = self.put_request(self._server_baseurl, req) | ||
| return ExtensionsServer.from_response(response.content, self.parent_srv.namespace) | ||
|
|
||
| @api(version="3.21") |
There was a problem hiding this comment.
For the site settings, I wonder if we should just use 3.27 here? The methods were added in 3.21, but the new trusted items and such weren't added until 3.27. Thoughts?
There was a problem hiding this comment.
@jacksonlauren Would there be any problems in the server side < 3.27 if the user erroneously includes trusted items or other 3.27+ items? If no, I think we leave it at 3.21. If yes, then bump to 3.27
jorwoods
force-pushed
the
jorwoods/extensions
branch
from
86a2f25 to
c24b7ff
Compare
Closes tableau#1629 New attributes have been added to extension site settings for upcoming Tableau Cloud releases.
jorwoods
force-pushed
the
jorwoods/extensions
branch
from
c24b7ff to
4e2c01b
Compare
Conversation with jacksonlauren indicated that if the ExtensionSiteSettings safe list is None, no safeList element should be included in the request. If the ExtensionSiteSettings.safe_list is a non-None Iterable that yields 0 items, an empty safeList element will be included in the request, having the effect of deleting the safe list on the site.
3 participants
