-
Notifications
You must be signed in to change notification settings - Fork 69
Add GitHub Actions workflow to publish Docker images to GHCR #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution! Before we can merge this, we need @bbartels to sign the Salesforce Inc. Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds GitHub Actions workflow automation to build and publish Docker images to GitHub Container Registry (GHCR) when releases are published. The workflow supports multi-architecture builds (linux/amd64, linux/arm64), automatic semantic versioning, and manual workflow dispatch.
Changes:
- Adds
docker-publish.ymlworkflow for publishing to GHCR - Adds
publish-docker.ymlworkflow (appears to contain both Docker Hub and GHCR configurations with terminal artifacts)
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/docker-publish.yml |
Clean GHCR workflow with proper authentication and multi-arch support |
.github/workflows/publish-docker.yml |
Contains mixed Docker Hub/GHCR configuration with terminal output artifacts (lines 58-117) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @bbartels, thanks again for submitting this PR. Would it be alright with you if one of us internally resubmitted this PR with these changes? That would make it so you wouldn't need to mess with signing the CLA and we can iterate quickly if any follow-up changes are necessary without needing to bug you. :) |
|
I dont mind at all! Feel free |
|
Awesome, thanks. One last question: have these changes already been tested or used in a different repo in any way that I could reference? |
Just ran it on my fork: https://github.com/bbartels/tableau-mcp/actions/workflows/docker-publish.yml should just work as is |
|
https://github.com/bbartels/tableau-mcp/pkgs/container/tableau-mcp It published the container here once i created a new release |
|
That's awesome! Thanks again |
Summary
Features
1.2.3,1.2,1,latest)GITHUB_TOKENAdmin Setup Required
None! The workflow uses the built-in
GITHUB_TOKENand automaticpackages: writepermission.After the first publish, the package will appear at:
ghcr.io/<org>/<repo>(e.g.,ghcr.io/tableau/tableau-mcp)Optional: Package Visibility
By default, packages inherit the repository's visibility. If needed, admins can adjust package settings at:
Settings → Packages → tableau-mcp → Package settings
Usage
Pull the image: