go: add messager container provider #109
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kybxd
force-pushed
the
go-messager-container-provider
branch
from
cd647b2 to
c62681c
Compare
Kybxd
force-pushed
the
go-messager-container-provider
branch
from
e9139c1 to
d173be5
Compare
Kybxd
force-pushed
the
go-messager-container-provider
branch
from
3792631 to
0b02b55
Compare
wenchy
requested changes
Sep 11, 2025
| fmt.Printf("PatchReplaceConf: %v\n", hub.GetHub().GetPatchReplaceConf().Data()) | ||
| // print provided patch replace conf | ||
| fmt.Printf("PatchReplaceConf(provided): %v\n", hub.GetHub().ProvidedBy(ctx).GetPatchReplaceConf().Data()) | ||
| // print patch replace conf binding to background context |
There was a problem hiding this comment.
Please obey the context API convention amd design elegant APIs:
ctx := hub.GetHub().BindTo(ctx)->ctx = hub.NewContext(ctx, myhub)myhub := hub.GetHub().ProvidedBy(ctx)->myhub = hub.FromContext(ctx)
Refer to https://pkg.go.dev/context#Context
There was a problem hiding this comment.
We do not bind a hub to context, but bind its messager container. ctx = hub.NewContext(ctx, myhub) will lead to misunderstanding.
| @@ -0,0 +1,208 @@ | |||
| import ( | |||
There was a problem hiding this comment.
There is no need to add another abstraction: base hub.
"Keep it simple, stupid!"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.