Garage: add multi chain support #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RIG-51 Add support for connecting to multiple chains
The admin page needs to be able to write to tables on filecoin and the contracts that get called for training/piloting/parking/transferring rigs are on eth mainnet, so we need to support for switching the connected provider/wallet between networks depending on the context. This will also be needed for the voting feature since the registry contract & related tables will be deployed to a chain that is not eth mainnet (most likely filecoin?) |
we need to wrap the .run()-call in a try/catch so that we can catch exceptions thrown if the user rejects the transaction
datadanne
force-pushed
the
datadanne/add-multi-chain-support
branch
from
16ac3d4
to
7b10568
Compare
sweet! will need a re-approval since the base changed to staging |
sanderpick
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to the garage for being connected to multiple chains. Needed when using the admin page to write to tables that are not on mainnet, and will be needed for voting
NOTE: The base of this PR is #878 and not staging, because it depends on the work in 878. Will change base as soon as that one is merged
Closes RIG-51